[REVIEW] Documentation enhancements to cudf python APIs - #5213
Merged
Merged
Conversation
Collaborator
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
kkraus14
reviewed
May 22, 2020
kkraus14
suggested changes
May 22, 2020
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
Co-authored-by: Keith Kraus <keith.j.kraus@gmail.com>
kkraus14
approved these changes
May 26, 2020
Contributor
Author
|
rerun tests |
mike-wendt
approved these changes
May 26, 2020
This was referenced May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5210
Fixes: #3075
Fixes: #2681
Fixes: #5143
.strsupport forIndex..cat.codesis not assigning an index to the series.Fixed this issue.
rdiv, an alias tortruedivIndex.argsortwas returning aNumericalColumn, pandas returns anumpyarray. Fixed this by making it returncupyarray.Index.to_seriesshould actually return a series of values and index of itself to the series, fixed this issue as well.start&stopproperties forRangeIndex.Series.copyseems to be creating a copy for index in case of adeepcopy, fixed this issue too: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.copy.htmlunique_k(deprecated 3 years back) and it’s associateddask_cudfmethods.