Reenable fixed GroupBy value_counts tests in pandas shards - #24080
Reenable fixed GroupBy value_counts tests in pandas shards#24080galipremsagar wants to merge 3 commits into
Conversation
These nine skips report KeyError for a column added after groupby creation. Intermediate proxies have re-derived against mutated parents since d227e8d (NVIDIA#22998), which removed related ordinary xfails but left these shard-only skips. All nine cases pass in isolation and both full module shards. The full value_counts module passes independently; both stack/value_counts shards also pass when integrated with the per-instance descriptor-dispatch fix.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 0 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe pandas testing plugin no longer skips nine ChangesGroupby value-counts test enablement
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Nine previously skipped GroupBy value-count tests are enabled, with the supplied test results showing they pass in targeted and broader test runs. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/okay to test eb51e89 |
|
/okay to test 3a69e57 |
Description
Remove nine stale GroupBy value_counts entries from
NODEIDS_TO_SKIP_WHEN_SHARDED(#22992).The original CI failures were
KeyError: Column not found: both: these tests create a GroupBy, add a column to its parent DataFrame, then select that column through the existing GroupBy. #22998 already fixed this stale-parent intermediate-proxy bug and added regression coverage, but these shard-only skips remained.Independent main-based, marker-only change.
Validation
Tested with pandas 3.0.3 and source Python using installed cuDF 26.10 native libraries (main is 26.12), with an external hook for the installed extension and exact GPU mask API rename. No environment or vendored pandas test changes were made. Matching native-library validation remains for CI.