Reenable fixed figure-pickling tests in pandas shards - #24070
Reenable fixed figure-pickling tests in pandas shards#24070galipremsagar wants to merge 3 commits into
Conversation
Remove four shard skips left over from strict XPASS failures before the Period and concrete offset pickle reducers added in NVIDIA#23054. Figure pickling now passes both with normal plotting options and after xaxis.compat is enabled.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe pandas testing plugin removes four known-failure skip entries for ChangesPlot pickle tests
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change reenables four plotting pickle test cases. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/okay to test 8fb7e0a |
|
/okay to test 1ca305b |
Description
Remove four stale figure-pickling entries from
NODEIDS_TO_SKIP_WHEN_SHARDED(#22992). Period and concrete-offset pickle reducers added by #23054 already resolve this group on main.This is a marker-only change on an independent main-based branch. It is separate from the plotting-option isolation fix: these four cases pass even after the known
xaxis.compatpolluter.Validation
Tested with pandas 3.0.3 and checked-out Python sources. Local native libraries are cuDF 26.10 (main is 26.12); an external startup hook loads the installed extension and maps the exact GPU mask API rename. No CPU implementation substitute or environment modifications were used. Matching native-library validation remains for CI. Plotting itself intentionally uses pandas/Matplotlib.