Skip to content

Reenable fixed figure-pickling tests in pandas shards - #24070

Open
galipremsagar wants to merge 3 commits into
NVIDIA:mainfrom
galipremsagar:enable-cudf-pandas-plot-pickle-shards
Open

Reenable fixed figure-pickling tests in pandas shards#24070
galipremsagar wants to merge 3 commits into
NVIDIA:mainfrom
galipremsagar:enable-cudf-pandas-plot-pickle-shards

Conversation

@galipremsagar

Copy link
Copy Markdown
Contributor

Description

Remove four stale figure-pickling entries from NODEIDS_TO_SKIP_WHEN_SHARDED (#22992). Period and concrete-offset pickle reducers added by #23054 already resolve this group on main.

This is a marker-only change on an independent main-based branch. It is separate from the plotting-option isolation fix: these four cases pass even after the known xaxis.compat polluter.

Validation

  • All 12 figure-pickling cases passed.
  • All four previously skipped cases pass with normal plotting options and after the option polluter.
  • Independent full plotting shards: 569 passed / 584 passed, zero failures, with the other plotting skips retained.
  • Ruff and whitespace checks passed.

Tested with pandas 3.0.3 and checked-out Python sources. Local native libraries are cuDF 26.10 (main is 26.12); an external startup hook loads the installed extension and maps the exact GPU mask API rename. No CPU implementation substitute or environment modifications were used. Matching native-library validation remains for CI. Plotting itself intentionally uses pandas/Matplotlib.

Remove four shard skips left over from strict XPASS failures before the Period and concrete offset pickle reducers added in NVIDIA#23054. Figure pickling now passes both with normal plotting options and after xaxis.compat is enabled.
@galipremsagar
galipremsagar requested a review from a team as a code owner September 9, 2026 17:01
@copy-pr-bot

copy-pr-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fcc552ae-6244-45d6-a6a6-6a30959011c1

📥 Commits

Reviewing files that changed from the base of the PR and between 310b5be and f72dace.

📒 Files selected for processing (1)
  • python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
💤 Files with no reviewable changes (1)
  • python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Plotting pickle tests are no longer skipped, allowing them to run as part of the pandas test suite.

Walkthrough

The pandas testing plugin removes four known-failure skip entries for TestTSPlot.test_pickle_fig cases involving DataFrame and Series inputs.

Changes

Plot pickle tests

Layer / File(s) Summary
Remove plotting pickle skips
python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
Removes skip configuration for four TestTSPlot.test_pickle_fig cases covering DataFrame and Series inputs.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1ca30

This change reenables four plotting pickle test cases. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: re-enabling fixed figure-pickling tests in pandas shards.
Description check ✅ Passed The description directly explains the four removed skip entries, the supporting fixes, and the validation results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 9, 2026
@galipremsagar

Copy link
Copy Markdown
Contributor Author

/okay to test 8fb7e0a

@galipremsagar

Copy link
Copy Markdown
Contributor Author

/okay to test 1ca305b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf.pandas Issues specific to cudf.pandas improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant