Skip to content

Skip upstream polars test test_scan_ndjson_streaming_decompression - #23783

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:bug/polars/cpu-decompress-ndjson-slice
Aug 24, 2026
Merged

Skip upstream polars test test_scan_ndjson_streaming_decompression#23783
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:bug/polars/cpu-decompress-ndjson-slice

Conversation

@Matt711

@Matt711 Matt711 commented Aug 24, 2026

Copy link
Copy Markdown
Member

Description

Discovered in #23517

Lets skip it for now until the bug is fixed in Polars.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711
Matt711 requested a review from a team as a code owner August 24, 2026 18:01
@Matt711
Matt711 requested a review from msarahan August 24, 2026 18:01
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f01e2444-7470-44f1-adfa-77f2b6b81b0c

📥 Commits

Reviewing files that changed from the base of the PR and between f64d69a and bc8cf67.

📒 Files selected for processing (1)
  • ci/run_cudf_polars_polars_tests.sh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Added coverage for NDJSON streaming decompression scenarios in Polars.
    • Included cases involving decompression of full streams when slice limits are applied.

Walkthrough

The Polars test runner now deselects two NDJSON streaming decompression tests. The deselections cite Polars issue 28954.

Changes

Polars test runner

Layer / File(s) Summary
NDJSON decompression test deselections
ci/run_cudf_polars_polars_tests.sh
The deselected test list includes schema-specified and schema-less NDJSON streaming decompression tests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bc8cf

This localized change only skips a known upstream test, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: msarahan, tomaugspurger, wence-

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains that the upstream Polars test is skipped until the related decompression bug is fixed.
Title check ✅ Passed The title clearly identifies the skipped upstream Polars test, which is the main change in the pull request.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Matt711

Matt711 commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 33d8253 into NVIDIA:main Aug 24, 2026
148 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants