Skip to content

Handle int64 strings offsets in cudf::byte_cast API #23725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwendt wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −7
Open

Handle int64 strings offsets in cudf::byte_cast API #23725

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a3593a
Handle large strings offsets in cudf::byte_cast API
davidwendt Aug 19, 2026
d316170
Merge branch 'main' into ls-byte-cast
davidwendt Aug 20, 2026
c9ec30f
Merge branch 'main' into ls-byte-cast
davidwendt Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions cpp/src/reshape/byte_cast.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -8,6 +8,7 @@
#include <cudf/detail/copy.hpp>
#include <cudf/detail/null_mask.hpp>
#include <cudf/detail/nvtx/ranges.hpp>
#include <cudf/detail/unary.hpp>
#include <cudf/lists/detail/lists_column_factories.hpp>
#include <cudf/reshape.hpp>
#include <cudf/strings/detail/strings_children.cuh>
Expand Down Expand Up @@ -130,12 +131,16 @@ struct byte_list_conversion_fn<T, std::enable_if_t<std::is_same_v<T, cudf::strin
auto uint8_col = std::make_unique<column>(
output_type, num_chars, std::move(*(col_content.data)), rmm::device_buffer{}, 0);

auto result = make_lists_column(
input.size(),
std::move(col_content.children[cudf::strings_column_view::offsets_column_index]),
std::move(uint8_col),
input.null_count(),
detail::copy_bitmask(input, stream, mr));
auto offsets_col = std::move(col_content.children[strings_column_view::offsets_column_index]);
if (offsets_col->type().id() != type_id::INT32) {
offsets_col = cudf::detail::cast(offsets_col->view(), data_type{type_id::INT32}, stream, mr);
}

auto result = make_lists_column(input.size(),
std::move(offsets_col),
std::move(uint8_col),
input.null_count(),
detail::copy_bitmask(input, stream, mr));

// If any nulls are present, the corresponding lists must be purged so that
// the result is sanitized.
Expand Down
Loading