Skip to content

Fix invalid device context error in ValidIfTest.ExplicitMemoryResourcesEmptyRange #23704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
Aug 18, 2026
Merged

Fix invalid device context error in ValidIfTest.ExplicitMemoryResourcesEmptyRange #23704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions cpp/tests/bitmask/valid_if_tests.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,20 @@ TEST_F(ValidIfTest, ExplicitMemoryResourcesEmptyRange)
auto harness = cudf::test::memory_resource_test_harness{this->mr()};
auto stream = cudf::get_default_stream();

// No harness.synchronize inside the scope: empty range has no GPU operations pending.
auto actual = [&] {
auto current_scope = harness.fail_on_current_device_resource_use();
auto result = cudf::detail::valid_if(cuda::counting_iterator<cudf::size_type>{0},
cuda::counting_iterator<cudf::size_type>{0},
odds_valid{},
stream,
harness.resources());
harness.synchronize(stream);
return result;
return cudf::detail::valid_if(cuda::counting_iterator<cudf::size_type>{0},
cuda::counting_iterator<cudf::size_type>{0},
odds_valid{},
stream,
harness.resources());
}();

EXPECT_EQ(0u, actual.first.size());
EXPECT_EQ(nullptr, actual.first.data());
EXPECT_EQ(0, actual.second);
harness.expect_no_live_allocations(stream);
// total == 0 implies value == 0; no sync needed since no allocations were ever made.
EXPECT_EQ(0, harness.output_mr().get_bytes_counter().total);
EXPECT_EQ(0, harness.temporary_mr().get_bytes_counter().total);
}
Expand Down
Loading