Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,9 @@ def serialize(self, engine: StreamingEngine | None) -> dict:
config_options = config_options.drop_unserializable()
rapidsmpf_options = engine.rapidsmpf_options.get_strings()
result["config_options"] = {
"config_options": dataclasses.asdict(config_options),
"config_options": dataclasses.asdict(
config_options, dict_factory=ConfigOptions.dict_factory
),
"rapidsmpf_options": rapidsmpf_options,
}
# discard unserializable / unnecessary UUIDs
Expand Down
21 changes: 21 additions & 0 deletions python/cudf_polars/cudf_polars/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -1002,6 +1002,27 @@ class ConfigOptions(Generic[ExecutorType]):
device: int | None = None
memory_resource_config: MemoryResourceConfig | None = None

@staticmethod
def dict_factory(items: list[tuple[str, Any]]) -> dict[str, Any]:
"""
``dict_factory`` for :func:`dataclasses.asdict`.

Converts any :data:`UNSPECIFIED` value to ``None``
(e.g. ParquetOptions.prefetch_file_metadata) so the resulting
dict can be serialized with :func:`json.dumps`.

Parameters
----------
items
The ``(key, value)`` pairs for a single dataclass level, as passed
by :func:`dataclasses.asdict`.

Returns
-------
A dict with :data:`UNSPECIFIED` values replaced by ``None``.
"""
return {k: (None if isinstance(v, Unspecified) else v) for k, v in items}

def drop_unserializable(self) -> ConfigOptions[ExecutorType]:
"""
Return a copy safe to pickle to a worker/actor.
Expand Down
11 changes: 11 additions & 0 deletions python/cudf_polars/tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

from __future__ import annotations

import dataclasses
from typing import cast

import pytest
Expand Down Expand Up @@ -553,6 +554,16 @@ def test_parquet_options_object_engine_default() -> None:
assert isinstance(config.parquet_options.prefetch_file_metadata, Unspecified)


def test_parquet_options_unspecified_dict_factory() -> None:
parquet_options = ParquetOptions()
config = ConfigOptions.from_polars_engine(
pl.GPUEngine(executor="streaming", parquet_options=parquet_options)
)
assert isinstance(config.parquet_options.prefetch_file_metadata, Unspecified)
result = dataclasses.asdict(config, dict_factory=ConfigOptions.dict_factory)
assert result["parquet_options"]["prefetch_file_metadata"] is None
Comment thread
mroeschke marked this conversation as resolved.


def test_validate_raise_on_fail() -> None:
with pytest.raises(TypeError, match="'raise_on_fail' must be"):
ConfigOptions.from_polars_engine(
Expand Down
Loading