Skip to content

Migrate T-digest test helpers to memory_resources #23608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdice wants to merge 8 commits into
base: main
Choose a base branch
from
+319 −154
Open

Migrate T-digest test helpers to memory_resources #23608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebc9efb
Migrate T-digest test helpers to memory_resources
bdice Aug 10, 2026
c8dee67
Merge remote-tracking branch 'origin/main' into test-mr-tdigest-main
nirandaperera Aug 18, 2026
b63ca1c
thread stream arg throguh
nirandaperera Aug 19, 2026
ac38b84
use basefixture
nirandaperera Aug 19, 2026
913cff7
Merge branch 'main' of github.com:rapidsai/cudf into test-mr-tdigest-…
nirandaperera Aug 19, 2026
f118cd8
Merge branch 'main' into test-mr-tdigest-main
bdice Aug 20, 2026
f05ab9e
Merge branch 'main' of github.com:rapidsai/cudf into test-mr-tdigest-…
nirandaperera Aug 26, 2026
e335969
Merge branch 'main' into test-mr-tdigest-main
nirandaperera Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cpp/include/cudf_test/base_fixture.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ struct BaseFixtureWithHarness : public BaseFixture {
*/
cudf::memory_resources resources() { return _harness.resources(); }

protected:
/**
* @brief Return the memory-resource harness used by this fixture.
*/
[[nodiscard]] memory_resource_test_harness& harness() noexcept { return _harness; }

memory_resource_test_harness _harness{mr()};
};

Expand Down
24 changes: 18 additions & 6 deletions cpp/include/cudf_test/memory_resource_utilities.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,28 @@ class memory_resource_test_harness {
/** @brief Synchronize `stream` before leaving a failing-resource API scope. */
void synchronize(cuda::stream_ref stream = cudf::test::get_default_stream()) const;

/** @brief Assert that output allocations are live after synchronizing `stream`. */
void expect_output_allocations_live(
/**
* @brief Assert that output allocations are live after synchronizing `stream`.
*
* @return Output-resource byte counters after the assertion
*/
rmm::mr::statistics_resource_adaptor::counter expect_output_allocations_live(
cuda::stream_ref stream = cudf::test::get_default_stream()) const;

/** @brief Assert that temporary allocations were made after synchronizing `stream`. */
void expect_temporary_allocation_activity(
/**
* @brief Assert that temporary allocations were made after synchronizing `stream`.
*
* @return Temporary-resource byte counters after the assertion
*/
rmm::mr::statistics_resource_adaptor::counter expect_temporary_allocation_activity(
cuda::stream_ref stream = cudf::test::get_default_stream()) const;

/** @brief Assert that no temporary allocations remain live after synchronizing `stream`. */
void expect_temporary_allocations_released(
/**
* @brief Assert that no temporary allocations remain live after synchronizing `stream`.
*
* @return Temporary-resource byte counters after the assertion
*/
rmm::mr::statistics_resource_adaptor::counter expect_temporary_allocations_released(
cuda::stream_ref stream = cudf::test::get_default_stream()) const;

/**
Expand Down
Loading