Skip to content

ensure nightly builds always produce new packages, expand 'changed-files' lists - #23533

Merged
rapids-bot[bot] merged 12 commits into
NVIDIA:mainfrom
jameslamb:nightly-versions
Aug 5, 2026
Merged

ensure nightly builds always produce new packages, expand 'changed-files' lists#23533
rapids-bot[bot] merged 12 commits into
NVIDIA:mainfrom
jameslamb:nightly-versions

Conversation

@jameslamb

Copy link
Copy Markdown
Member

Contributes to rapidsai/build-planning#218

For wheels:

# before
26.10.0a55 

# after
26.10.0a55.post260803200854

And for conda:

# before
26.10.0a55[build=cuda12_260803_9da146ef]

# after
26.10.0a55[build=cuda12_260803200854_9da146ef]

Other changes:

  • updates changed-files lists to avoid triggering test jobs in PR CI when only .github/workflows/{build,test}.yaml are changed

Notes for Reviewers

How I tested this

See rapidsai/cugraph-gnn#508

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 4, 2026
@jameslamb jameslamb changed the title ensure nightly builds always produce new packages WIP: ensure nightly builds always produce new packages Aug 4, 2026
@jameslamb jameslamb changed the title WIP: ensure nightly builds always produce new packages ensure nightly builds always produce new packages Aug 5, 2026
@jameslamb
jameslamb marked this pull request as ready for review August 5, 2026 01:51
@jameslamb
jameslamb requested review from a team as code owners August 5, 2026 01:51
@jameslamb
jameslamb requested a review from msarahan August 5, 2026 01:51
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • Build and Packaging

    • Build artifacts and package versions now include a consistent, more precise datetime identifier.
    • Wheel and Conda package build strings use the updated timestamp format.
    • C++ and Python builds now receive the same build datetime information.
  • CI Improvements

    • Pull request and build workflows share build metadata consistently.
    • Workflow change detection avoids unnecessary rebuilds for unrelated configuration updates.

Walkthrough

The workflows now generate one shared build datetime and pass it to C++, Python, Conda, and wheel builds. Build scripts and recipes use RAPIDS_DATETIME_STRING. Wheel versions receive a .post suffix.

Changes

Build datetime workflow integration

Layer / File(s) Summary
Workflow build datetime propagation
.github/workflows/build.yaml, .github/workflows/pr.yaml
Adds the reusable build-details job and passes its build-datetime output to C++, Python, Conda, and wheel jobs.
Workflow changed-file filters
.github/workflows/pr.yaml
Excludes build.yaml and test.yaml from the relevant changed-file filters.
Build timestamp consumers
ci/build_*.sh, conda/recipes/*/recipe.yaml
Replaces RAPIDS_DATE_STRING with RAPIDS_DATETIME_STRING. Conda build strings and wheel version files use the datetime value.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • rapidsai/cudf#23174: Both PRs modify wheel-build jobs in the CI workflows, but this PR changes build metadata and dependencies.

Suggested reviewers: msarahan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the nightly package versioning and changed-files workflow updates.
Description check ✅ Passed The description directly explains the nightly package versioning changes and changed-files workflow updates.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@conda/recipes/libcudf/recipe.yaml`:
- Line 305: Move the string key from the build.script.env section to the build
level, alongside the script configuration, while preserving its existing
cuda_major, datetime_string, and head_rev expression so libcudf-example receives
the intended unique build string.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a839e81f-3a26-4bd3-a547-d2c41e025c81

📥 Commits

Reviewing files that changed from the base of the PR and between 079ebcb and bb48ae0.

📒 Files selected for processing (14)
  • .github/workflows/build.yaml
  • .github/workflows/pr.yaml
  • ci/build_cpp.sh
  • ci/build_python.sh
  • ci/build_python_noarch.sh
  • ci/build_wheel.sh
  • conda/recipes/cudf-polars/recipe.yaml
  • conda/recipes/cudf/recipe.yaml
  • conda/recipes/cudf_kafka/recipe.yaml
  • conda/recipes/cudf_streaming/recipe.yaml
  • conda/recipes/custreamz/recipe.yaml
  • conda/recipes/dask-cudf/recipe.yaml
  • conda/recipes/libcudf/recipe.yaml
  • conda/recipes/pylibcudf/recipe.yaml

Comment thread conda/recipes/libcudf/recipe.yaml Outdated
@jameslamb jameslamb changed the title ensure nightly builds always produce new packages ensure nightly builds always produce new packages, expand 'changed-files' lists- #2414 #2414 Aug 5, 2026
@jameslamb jameslamb changed the title ensure nightly builds always produce new packages, expand 'changed-files' lists- #2414 #2414 ensure nightly builds always produce new packages, expand 'changed-files' lists Aug 5, 2026
@jameslamb

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit eca9e72 into NVIDIA:main Aug 5, 2026
147 of 148 checks passed
@jameslamb
jameslamb deleted the nightly-versions branch August 5, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants