Fix flaky cudf-polars Quent integration test - #23482
Conversation
On `main`, the following will error reliably: ``` pytest -p no:randomly -n0 \ python/cudf_polars/tests/streaming/test_ray.py::test_yields_engine \ python/cudf_polars/tests/quent/test_quent_integration.py ``` In CI, it will fail if a worker that previously happened to run one of the ray tests with 0 GPUs happened to worksteal the quent integration tests. This fixes the issue by passing through `ray_init_options` and `ray_num_ranks` when creating the RayEngine for the quent tests, similar to the rest of the tests Closees NVIDIA#23441
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Quent integration fixture now accepts Ray rank and initialization options, passes them to ChangesRay Quent fixture
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
vyasr
left a comment
There was a problem hiding this comment.
Approving for now to avoid the issues, although it would be nice if there was a context manager or similar approach that we could do to avoid global state mutations causing problems like this.
|
Agreed, though I'm not sure how easy that is to do... Our tests really do need to share the underlying Ray cluster resources between tests, since they're so expensive to create. The current API of |
|
/merge |
|
/merge |
Description
On
mainandrelease/26.08, the following will error reliably:In CI, it will fail if a worker that previously happened to run one of the ray tests with 0 GPUs happened to worksteal the quent integration tests.
This fixes the issue by passing through
ray_init_optionsandray_num_rankswhen creating the RayEngine for the quent tests, similar to the rest of the testsCloses #23441
Checklist