Skip to content

Remove deprecated sum_with_overflow APIs - #23475

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
PointKernel:agent/remove-deprecated-sum-overflow-apis
Jul 30, 2026
Merged

Remove deprecated sum_with_overflow APIs#23475
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
PointKernel:agent/remove-deprecated-sum-overflow-apis

Conversation

@PointKernel

Copy link
Copy Markdown
Member

Description

This PR removes the deprecated SUM_WITH_OVERFLOW, make_sum_with_overflow_aggregation(), and Java sumWithOverflow() compatibility APIs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel PointKernel added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 29, 2026
@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test fa8bc43

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. Java Affects Java cuDF API. labels Jul 29, 2026
@PointKernel

Copy link
Copy Markdown
Member Author

/ok to test aff809c

@PointKernel
PointKernel marked this pull request as ready for review July 30, 2026 04:44
@PointKernel
PointKernel requested review from a team as code owners July 30, 2026 04:44
@PointKernel
PointKernel requested review from abigalekim and wence- July 30, 2026 04:44
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d19d14b3-4d19-472d-a123-875048635bf8

📥 Commits

Reviewing files that changed from the base of the PR and between d466e60 and aff809c.

📒 Files selected for processing (6)
  • cpp/include/cudf/aggregation.hpp
  • cpp/src/aggregation/aggregation.cpp
  • java/src/main/java/ai/rapids/cudf/Aggregation.java
  • java/src/main/java/ai/rapids/cudf/GroupByAggregation.java
  • java/src/main/java/ai/rapids/cudf/ReductionAggregation.java
  • java/src/test/java/ai/rapids/cudf/ReductionTest.java
💤 Files with no reviewable changes (5)
  • java/src/main/java/ai/rapids/cudf/GroupByAggregation.java
  • java/src/main/java/ai/rapids/cudf/Aggregation.java
  • java/src/test/java/ai/rapids/cudf/ReductionTest.java
  • java/src/main/java/ai/rapids/cudf/ReductionAggregation.java
  • cpp/src/aggregation/aggregation.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Breaking Changes
    • Removed deprecated sumWithOverflow aggregation APIs and enum aliases across C++ and Java interfaces.
    • Use the supported sumOverflow aggregation APIs instead.
  • Tests
    • Removed coverage for the retired sumWithOverflow alias.

Walkthrough

Removes deprecated sum-with-overflow aliases from the C++ and Java aggregation APIs, including the C++ enum and factory exports, Java factory methods, and the corresponding reduction alias test.

Changes

Sum-overflow alias removal

Layer / File(s) Summary
C++ API and export removal
cpp/include/cudf/aggregation.hpp, cpp/src/aggregation/aggregation.cpp
Removes the deprecated SUM_WITH_OVERFLOW enum alias and make_sum_with_overflow_aggregation() declarations, implementation, and exported instantiations.
Java API and test cleanup
java/src/main/java/ai/rapids/cudf/{Aggregation,GroupByAggregation,ReductionAggregation}.java, java/src/test/java/ai/rapids/cudf/ReductionTest.java
Removes deprecated sumWithOverflow() factories and the test covering the reduction alias.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • rapidsai/cudf#23014: Earlier renaming and deprecation work introduced the SUM_OVERFLOW API while retaining these deprecated aliases.

Suggested labels: 3 - Ready for Review

Suggested reviewers: mhaseeb123, bdice, davidwendt

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the removal of deprecated sum-with-overflow APIs.
Description check ✅ Passed The description matches the changes by naming the deprecated C++ and Java compatibility APIs removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@PointKernel

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 539129b into NVIDIA:main Jul 30, 2026
136 checks passed
@PointKernel
PointKernel deleted the agent/remove-deprecated-sum-overflow-apis branch July 30, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants