Upgrade to nvcomp 5.3.0.16 - #23456
Merged
josephine-wolf-oberholtzer merged 17 commits intoJul 29, 2026
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
libcudf
Contributor
Author
|
/okay to test |
Contributor
Author
|
/okay to test |
robertmaynard
force-pushed
the
nvcomp-5.3.0.16-corrected
branch
from
July 28, 2026 13:08
7681de2 to
646029a
Compare
Contributor
Author
|
/okay to test |
robertmaynard
force-pushed
the
nvcomp-5.3.0.16-corrected
branch
from
July 28, 2026 13:20
646029a to
5a86679
Compare
Contributor
Author
|
/okay to test |
Contributor
Author
|
/okay to test |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@java/src/main/native/CMakeLists.txt`:
- Around line 270-282: Update the get_target_property call for cudf::cudf to use
CUDF_STATIC_LINKED_PROJECTS, preserving the existing nvcomp IN_LIST check so
static cudf linkage selects nvcomp::nvcomp_static and other cases select
nvcomp::nvcomp.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f0b66f77-494c-4833-bba7-6897f5d9e8cd
📒 Files selected for processing (10)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamlconda/recipes/libcudf/conda_build_config.yamlcpp/CMakeLists.txtcpp/cmake/thirdparty/get_nvcomp.cmakedependencies.yamljava/src/main/native/CMakeLists.txtpython/libcudf/pyproject.toml
jameslamb
approved these changes
Jul 29, 2026
KyleFromNVIDIA
approved these changes
Jul 29, 2026
jihoonson
approved these changes
Jul 29, 2026
Contributor
Author
|
/merge |
mythrocks
reviewed
Jul 29, 2026
mythrocks
approved these changes
Jul 29, 2026
bdice
approved these changes
Jul 29, 2026
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
A couple questions, but approving to unblock once those are answered.
Comment on lines
+1364
to
+1365
| # Specify the target module library dependencies We do this after all the WHOLE_ARCHIVES to protect | ||
| # against any of these libraries ever adding a rapids_logger / rmm hidden dependency |
Contributor
There was a problem hiding this comment.
Suggested change
| # Specify the target module library dependencies We do this after all the WHOLE_ARCHIVES to protect | |
| # against any of these libraries ever adding a rapids_logger / rmm hidden dependency | |
| # Specify the target module library dependencies. We do this after all the WHOLE_ARCHIVES to protect | |
| # against any of these libraries ever adding a rapids_logger / rmm hidden dependency. |
3 tasks
Contributor
|
/merge |
1 similar comment
Contributor
|
/merge |
josephine-wolf-oberholtzer
merged commit Jul 29, 2026
4a902a2
into
NVIDIA:release/26.08
150 checks passed
rapids-bot Bot
pushed a commit
to rapidsai/docs
that referenced
this pull request
Jul 29, 2026
The 26.08 release will use nvcomp 5.3.0.16 and CCCL 3.4.1. This updates the pinning accordingly. Depends on NVIDIA/cudf#23456. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Joséphine Wolf Oberholtzer (https://github.com/josephine-wolf-oberholtzer) URL: #812
Contributor
|
I just realized that this was merged into the release branch for |
This was referenced Jul 31, 2026
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrades nvcomp to version 5.3.0.16.
Depends on rapidsai/rmm#2462.
Replaces #23294.
Checklist