Include sources.jar and javadoc.jar in the Java Maven repo output - #23389
Conversation
Align the java-build and java-gather artifact set with what Maven Central requires for a release (main classifier JAR, sources.jar, javadoc.jar, POM).
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesJava artifact publishing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
java/ci/README.md (1)
48-53: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd language identifiers to both fenced examples.
Both blocks trigger markdownlint MD040 because their fences are untyped.
java/ci/README.md#L48-L53: change the Step 2 output-tree fence to```text.java/ci/README.md#L79-L85: change the Step 3 repository-layout fence to```text.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@java/ci/README.md` around lines 48 - 53, Type both untyped fenced examples as text to satisfy markdownlint MD040: update the Step 2 output-tree fence at java/ci/README.md lines 48-53 and the Step 3 repository-layout fence at java/ci/README.md lines 79-85 to use the text language identifier.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@java/ci/README.md`:
- Around line 48-53: Type both untyped fenced examples as text to satisfy
markdownlint MD040: update the Step 2 output-tree fence at java/ci/README.md
lines 48-53 and the Step 3 repository-layout fence at java/ci/README.md lines
79-85 to use the text language identifier.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: af7adc7b-d960-4d7b-8211-4ec23183cd27
📒 Files selected for processing (3)
java/ci/README.mdjava/ci/assemble_maven_repo.shjava/ci/build_cudf_java_jar_in_container.sh
| # | ||
| # Output layout: | ||
| # <output-dir>/ai/rapids/cudf/<version>/cudf-<version>-<classifier>.jar | ||
| # <output-dir>/ai/rapids/cudf/<version>/cudf-<version>-sources.jar |
There was a problem hiding this comment.
The intended Maven repository must contain an unclassified primary artifact like cudf-26.08.0.jar for the release deploying.
Please remember to generate the unclassified primary artifact
There was a problem hiding this comment.
Good point. Since the unclassified primary artifact is semantically the same as one of the generated artifacts (i.e. cudf-26.08.0-cuda12.jar), the plan is to create this artifact in the publication workflow.
|
/merge |
Description
Align the
java-buildandjava-gatherartifact set with what Maven Central requires for a release (main classifier JAR, sources.jar, javadoc.jar, POM).Checklist