Add common load factor validation for joins - #23379
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughJoin load-factor validation is centralized in ChangesJoin load-factor validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Description
This PR adds a common
cudf::detail::checked_load_factorhelper and uses it acrosscudf::hash_join,cudf::distinct_hash_join,cudf::filtered_join, andcudf::mark_join.This ensures all hash-table joins validate the load factor before constructing CUCO storage and consistently throw
std::invalid_argumentfor values outside(0, 1]. It also adds the missing load-factor documentation and tests for filtered and mark joins.Checklist