Skip to content

RMM Library Linking Error Bug Fix - #23341

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:release/26.08from
abigalekim:ak/rmm-lib-fix
Jul 22, 2026
Merged

RMM Library Linking Error Bug Fix#23341
rapids-bot[bot] merged 4 commits into
NVIDIA:release/26.08from
abigalekim:ak/rmm-lib-fix

Conversation

@abigalekim

@abigalekim abigalekim commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #23348

Fixes build/CI by linking RMM to cuDF testing libraries.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@abigalekim
abigalekim requested a review from a team as a code owner July 20, 2026 18:42
@copy-pr-bot

copy-pr-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The cudftestutil INTERFACE target now publicly propagates rmm::rmm alongside its existing dependencies.

Changes

Build target linkage

Layer / File(s) Summary
Propagate RMM through cudftestutil
cpp/CMakeLists.txt
Adds rmm::rmm to the public link dependencies of the cudftestutil target.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: galipremsagar, msarahan, vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: fixing an RMM linking error by updating library linking.
Description check ✅ Passed The description is directly related to the changeset and explains the build/CI fix from linking RMM to cuDF testing libraries.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Jul 20, 2026
@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Please give a more descriptive title and add a description that describes the problem being fixed.

@abigalekim abigalekim changed the title CMake Fix RMM Library Linking Error Bug Fix Jul 20, 2026
@abigalekim

Copy link
Copy Markdown
Contributor Author

/ok to test a0083e7

@bdice

bdice commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Can you share the failures you’re observing? File an issue with a reproducer or include snippets and links of the CI logs.

@abigalekim

Copy link
Copy Markdown
Contributor Author

I created an issue with reproducibility. #23348

@bdice

bdice commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@abigalekim We should probably fix this in release/26.08 since it would be broken in the same way. Can you rebase this PR on that branch, and then change the target from main to release/26.08? (Please do it that order. Doing the target branch change first will ping a bunch of people.)

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bdice
bdice removed request for a team, galipremsagar, msarahan, vyasr and wence- July 20, 2026 21:34
@bdice bdice removed Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf-polars Issues specific to cudf-polars pylibcudf Issues specific to the pylibcudf package labels Jul 20, 2026
@bdice bdice removed this from cuDF Python Jul 20, 2026
@bdice bdice added this to libcudf Jul 20, 2026
@bdice bdice moved this to Burndown in libcudf Jul 20, 2026
@bdice

bdice commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

/merge

@GregoryKimball

GregoryKimball commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Thank you @abigalekim !

@abigalekim

abigalekim commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

Should we also push this to main and not just the upcoming release, since it will affect development as well?

@mhaseeb123

Copy link
Copy Markdown
Contributor

Should we also push this to main and not just the upcoming release, since it will affect development as well?

I think the next forward merge will take care of this in main 🙂

@rapids-bot
rapids-bot Bot merged commit fe0e78e into NVIDIA:release/26.08 Jul 22, 2026
258 of 261 checks passed
@abigalekim
abigalekim deleted the ak/rmm-lib-fix branch July 22, 2026 17:03
@GregoryKimball GregoryKimball moved this from Burndown to Landed in libcudf Jul 22, 2026
@GregoryKimball GregoryKimball removed this from libcudf Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

Status: Landed

Development

Successfully merging this pull request may close these issues.

[BUG] Building main fails due to rmm linking error in test suite

6 participants