-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Preserve masked integer dtypes in GroupBy cumsum/cumprod #23299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 11 commits into
NVIDIA:release/26.08
from
galipremsagar:groupby-cumscan-masked-dtype
Jul 22, 2026
+36
−9
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
455b357
Preserve masked integer dtypes in GroupBy cumsum/cumprod
galipremsagar 5e61811
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar e188265
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar c561b0b
Update python/cudf/cudf/core/groupby/groupby.py
galipremsagar 7a2c200
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar 001b0ca
Merge remote-tracking branch 'upstream/release/26.08' into groupby-cu…
galipremsagar 4f426ad
Merge remote-tracking branch 'upstream/release/26.08' into groupby-cu…
galipremsagar f49e2e6
Merge remote-tracking branch 'upstream/release/26.08' into groupby-cu…
galipremsagar b45e108
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar 4508892
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar 8fc070f
Merge branch 'release/26.08' into groupby-cumscan-masked-dtype
galipremsagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Performance & Scalability | 🟠 Major | 🏗️ Heavy lift
Add a unit benchmark for the new casting path.
The changed files add correctness tests but no benchmark for this feature/bug fix. Add a benchmark covering nullable-integer
cumsum/cumprod, ideally including representative group sizes and overflow cases, to track the cost of the post-scan cast.As per coding guidelines, “Add unit tests and unit benchmarks for feature and bug-fix contributions.”
🤖 Prompt for AI Agents
Source: Coding guidelines