Use setters in IO options builders instead of directly modifying the data members - #23267
Conversation
Route builder configuration through option setters so future validation is applied consistently.
Keep builder delegation compatible with reader quote parsing semantics.
📝 WalkthroughWalkthroughChangesIO option builder updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
davidwendt
left a comment
There was a problem hiding this comment.
Just want to point out that because these functions are coded in header files, all files that include them now need to be recompiled. If the definitions were moved to .cpp files then changing internal implementation details like this would only require those cpp files to be recompiled.
Yeah, we can move the definitions into a cpp file ( |
|
/merge |
…data members (NVIDIA#23267) Route IO builders through option setters because they are responsible for validation. Also fixed validation in `set_quoting`. Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - David Wendt (https://github.com/davidwendt) - Misiu Godfrey (https://github.com/misiugodfrey) URL: NVIDIA#23267
Description
Route IO builders through option setters because they are responsible for validation.
Also fixed validation in
set_quoting.Checklist