Repository navigation
Add memory resource parameter to cudf::hash_join constructors #23223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8e12597
Add memory resource parameter to cudf::hash_join constructors
PointKernel 782cb02
Fix doxygen copydoc warning in hash_join.hpp
PointKernel c2c5d7d
Merge remote-tracking branch 'upstream/main' into add-mr-hash-join
PointKernel 80fc944
Own the hash table memory resource via any_resource instead of a ref
PointKernel 269cfbb
Update explicit instantiations for any_resource constructor parameter
PointKernel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,26 +87,39 @@ class hash_join { | |
| * @param right The right table, from which the hash table is built | ||
| * @param compare_nulls Controls whether null join-key values should match or not | ||
| * @param stream CUDA stream used for device memory operations and kernel launches | ||
| * @param mr Device memory resource used to allocate the internal hash table, which must remain | ||
| * valid for the lifetime of this object | ||
| */ | ||
| hash_join(cudf::table_view const& right, | ||
| null_equality compare_nulls, | ||
| rmm::cuda_stream_view stream = cudf::get_default_stream()); | ||
| rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
| rmm::device_async_resource_ref mr = cudf::get_current_device_resource_ref()); | ||
|
|
||
| /** | ||
| * @copydoc hash_join(cudf::table_view const&, null_equality, rmm::cuda_stream_view) | ||
| * @brief Construct a hash join object for subsequent probe calls. | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| * | ||
| * @note The `hash_join` object must not outlive the table viewed by `right`, else behavior is | ||
| * undefined. | ||
| * | ||
| * @throws std::invalid_argument if the right table has no columns | ||
| * @throws std::invalid_argument if load_factor is not greater than 0 and less than or equal to 1 | ||
| * | ||
| * @param right The right table, from which the hash table is built | ||
| * @param has_nulls Flag to indicate if there exists any nulls in the `right` table or | ||
| * any `left` table that will be used later for join | ||
| * @param compare_nulls Controls whether null join-key values should match or not | ||
| * @param load_factor The hash table occupancy ratio in (0,1]. A value of 0.5 means 50% desired | ||
| * occupancy. | ||
| * @param stream CUDA stream used for device memory operations and kernel launches | ||
| * @param mr Device memory resource used to allocate the internal hash table, which must remain | ||
| * valid for the lifetime of this object | ||
| */ | ||
| hash_join(cudf::table_view const& right, | ||
| nullable_join has_nulls, | ||
| null_equality compare_nulls, | ||
| double load_factor, | ||
| rmm::cuda_stream_view stream = cudf::get_default_stream()); | ||
| rmm::cuda_stream_view stream = cudf::get_default_stream(), | ||
| rmm::device_async_resource_ref mr = cudf::get_current_device_resource_ref()); | ||
|
|
||
| /** | ||
| * Returns the row indices that can be used to construct the result of performing | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.