Skip to content

Set GPUS arguments on streaming tests - #23187

Closed
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:set-streaming-tests-gpus
Closed

Set GPUS arguments on streaming tests#23187
KyleFromNVIDIA wants to merge 1 commit into
NVIDIA:mainfrom
KyleFromNVIDIA:set-streaming-tests-gpus

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Description

Ensure that these GPU-based tests can only run one at a time.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Ensure that these GPU-based tests can only run one at a time.
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner July 8, 2026 19:35
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Jul 8, 2026
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0a37a248-dca7-402a-b578-d5b4080b0e75

📥 Commits

Reviewing files that changed from the base of the PR and between 0b01456 and 37446f3.

📒 Files selected for processing (1)
  • cpp/libcudf_streaming/tests/CMakeLists.txt

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated test registration so streaming tests are scheduled with full GPU availability and allocation settings.
    • This improves how the test suite runs in GPU-enabled environments and helps ensure consistent execution coverage.

Walkthrough

This change updates two rapids_test_add invocations in the libcudf_streaming test CMakeLists.txt to include GPUS ALL and PERCENT 100 scheduling parameters, applying to both mpirun-launched tests and the standalone single tests entry.

Changes

CMake GPU Test Scheduling

Layer / File(s) Summary
Add GPU scheduling parameters to test registration
cpp/libcudf_streaming/tests/CMakeLists.txt
Both the mpirun test add macro and the single tests registration now pass GPUS ALL and PERCENT 100 to rapids_test_add.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22864: Prior CMake test-registration changes in the same cpp/libcudf_streaming/tests/CMakeLists.txt file affecting rapids_test_add calls.

Suggested reviewers: bdice, vyasr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding GPUS args to streaming tests.
Description check ✅ Passed The description matches the changeset by stating the streaming GPU tests should run one at a time.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant