Skip to content

Use rapids_test_add() again - #23181

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:use-rapids_test_add
Jul 8, 2026
Merged

Use rapids_test_add() again#23181
rapids-bot[bot] merged 4 commits into
NVIDIA:mainfrom
KyleFromNVIDIA:use-rapids_test_add

Conversation

@KyleFromNVIDIA

Copy link
Copy Markdown
Member

Description

As of rapidsai/rapids-cmake#1050, rapids_test_install_relocatable() correctly relocates tests with arguments, so we can use rapids_test_add() again.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

As of rapidsai/rapids-cmake#1050,
`rapids_test_install_relocatable()` correctly relocates tests with
arguments, so we can use `rapids_test_add()` again.
@KyleFromNVIDIA
KyleFromNVIDIA requested a review from a team as a code owner July 8, 2026 15:24
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Non-breaking change labels Jul 8, 2026
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 56015e61-7bfb-450e-af57-8875cb2ca6ea

📥 Commits

Reviewing files that changed from the base of the PR and between 2988889 and 6481d05.

📒 Files selected for processing (1)
  • cpp/libcudf_streaming/tests/CMakeLists.txt
💤 Files with no reviewable changes (1)
  • cpp/libcudf_streaming/tests/CMakeLists.txt

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the test setup to use a standardized test registration and installation flow.
    • Improved how streaming tests are registered (including multi-rank runs) and installed, making execution more consistent across environments.
    • Simplified test packaging by removing custom install/path-rewrite logic and switching to a relocatable install approach.

Walkthrough

This PR migrates cpp/libcudf_streaming/tests/CMakeLists.txt to rapids-test helpers for test registration and relocatable installation.

Changes

Test registration and install migration

Layer / File(s) Summary
rapids-test initialization
cpp/libcudf_streaming/tests/CMakeLists.txt
Includes and initializes rapids-test, replacing the manual build-tree CTestTestfile.cmake setup.
mpirun and single-test registration
cpp/libcudf_streaming/tests/CMakeLists.txt
Registers mpirun and single-process tests with rapids_test_add, using $<TARGET_FILE:...> and INSTALL_COMPONENT_SET testing.
relocatable install wiring
cpp/libcudf_streaming/tests/CMakeLists.txt
Replaces the custom install and relocation script logic with rapids_test_install_relocatable for bin/gtests/libcudf_streaming.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • rapidsai/cudf#22864: Both PRs modify cpp/libcudf_streaming/tests/CMakeLists.txt and the mpirun-based test registration flow.
  • rapidsai/cudf#22954: Both PRs change test registration and install/relocation logic in the same CMake test setup.

Suggested reviewers: vyasr, bdice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching back to rapids_test_add().
Description check ✅ Passed The description is directly related to the test registration and relocatable install fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Comment thread cpp/libcudf_streaming/tests/CMakeLists.txt Outdated
@KyleFromNVIDIA

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 0b01456 into NVIDIA:main Jul 8, 2026
257 of 261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants