-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use rtcx from the librtcx repository #23137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0764ae6
feat: fetch librtcx via CPM instead of add_subdirectory
vyasr 185d02f
chore: remove bundled librtcx sources
vyasr 6c57281
ci: temporarily point rtcx CPM fetch at vyasr/librtcx@31a7295
vyasr 0c77b71
fix: exclude rtcx from install export set
vyasr 2720c1b
fix: properly export rtcx for static builds and install validation
vyasr f797da4
ci: update rtcx pin to include embed.cmake lazy-check fix
vyasr cb37005
ci: update rtcx pin to split-embed-cmake branch head
vyasr 4d97501
Update to latest commit
vyasr 1d4a13f
Merge remote-tracking branch 'upstream/main' into feat/external_rtccx
vyasr bf43e3a
Fix org
vyasr 2dec5d8
Pin librtcx to pre-cuVS commit
vyasr 7849e42
Fix librtcx commit hash
vyasr 9f20542
Merge branch 'main' into feat/external_rtccx
vyasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # cmake-format: off | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # cmake-format: on | ||
|
|
||
| # This function finds rtcx | ||
| function(find_and_configure_rtcx VERSION) | ||
|
|
||
| # Ensure rtcx installs its targets unconditionally. In shared builds the static library is | ||
| # absorbed into libcudf.so, but CMake still requires the target to be in an export set for | ||
| # install(EXPORT) validation. In static builds consumers need to link librtcx.a directly. | ||
| set(RTCX_INSTALL ON) | ||
|
|
||
| rapids_cpm_find( | ||
| rtcx ${VERSION} | ||
| GLOBAL_TARGETS rtcx::rtcx | ||
| CPM_ARGS | ||
| GIT_REPOSITORY https://github.com/rapidsai/librtcx.git | ||
| GIT_TAG efad266c1fd9de6d8486c6ba71bfa74df063eb1f | ||
| GIT_SHALLOW FALSE | ||
| EXCLUDE_FROM_ALL ${CUDF_EXCLUDE_DEPS_FROM_ALL} | ||
| ) | ||
|
|
||
| # When CPM fetches from source (add_subdirectory), embed.cmake is not auto-included. Include it | ||
| # explicitly so add_embed/embed_includes/embed functions are available. | ||
| if(rtcx_ADDED OR DEFINED CPM_rtcx_SOURCE) | ||
| include("${rtcx_SOURCE_DIR}/embed.cmake") | ||
| endif() | ||
| endfunction() | ||
|
|
||
| set(RTCX_MIN_VERSION_cudf "0.1") | ||
| find_and_configure_rtcx(${RTCX_MIN_VERSION_cudf}) | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.