Add instructions on running PDS-H for pandas - #23087
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds a new "PDS-H (TPC-H variant)" documentation section to the cudf.pandas benchmarks guide, covering installation, dataset generation with Decimal/date type conversion, CPU/GPU benchmark execution commands, and JSONL results format. It also simplifies the cudf-polars benchmarks documentation by removing GPU-specific preface text and the CPU-only source installation section. ChangesBenchmark Documentation Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: `improvement` Suggested reviewers: `rjzamora`, `TomAugspurger`, `mroeschke` 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/cudf/source/cudf_pandas/benchmarks.md`:
- Around line 125-139: The benchmark setup steps are missing the `pyarrow`
prerequisite, so the later casting workflow will fail in a clean environment.
Update the prerequisites in the `cudf_pandas` benchmark setup section to install
`pyarrow` alongside `cudf` and `tpchgen-cli`, and make sure the instructions
around the benchmark dataset generation mention this dependency so the
`pyarrow`/`pyarrow.parquet` imports succeed.
- Around line 173-179: The table conversion loop in the benchmarks flow can
silently skip a table when `parts` is empty, so update the logic around the `for
table in tables` block to fail fast instead of doing nothing. In the same path
that builds `table_path` and `parts`, add an explicit check for the empty case
and raise an error with a clear message when no parquet files are found for a
table, so unexpected layouts don’t go unnoticed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cd5524d1-beb3-4d42-abd9-2ad428cc9405
📒 Files selected for processing (3)
docs/cudf/source/cudf_pandas/benchmarks.mddocs/cudf/source/cudf_polars/benchmarks.mdpython/cudf/cudf/pandas/_benchmarks/utils.py
|
/merge |
Description
Documentation for humans and agents to refer to for reproducing our benchmarks.
Also removes CPU-benchmarking on CPU-only machines which we dont support right now.
Contributes to #17640
Checklist