Skip to content

Adjust verbosity of cudf-polars-polars-tests - #22980

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-polars-test-verbosity
Jun 26, 2026
Merged

Adjust verbosity of cudf-polars-polars-tests#22980
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
TomAugspurger:tom/cudf-polars-polars-test-verbosity

Conversation

@TomAugspurger

@TomAugspurger TomAugspurger commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

We run upstream polars tests with cudf-polars using two of or engines: in-memory and SPMD.

The recent CI failures running upstream polars tests have all been in the SPMD engine, while the in-memory engine has been passing fine. This change reduces the pytest verbosity for the in-memory run (making the logs easier to scan), and increases it for the SPMD run (hopefully helping with identifying the flaky tests).

The recent CI failures running upstream polars tests have all been in
the SPMD engine, not the in-memory engine. Reduce the test output for
in-memory, and increase it for SPMD.
@TomAugspurger
TomAugspurger requested a review from a team as a code owner June 25, 2026 11:50
@TomAugspurger TomAugspurger added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 25, 2026
@TomAugspurger
TomAugspurger requested a review from gforsyth June 25, 2026 11:50
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b496ff49-ea29-4cb0-a08f-62ce4a658a96

📥 Commits

Reviewing files that changed from the base of the PR and between 327a474 and 5fce0e7.

📒 Files selected for processing (1)
  • ci/run_cudf_polars_polars_tests.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci/run_cudf_polars_polars_tests.sh

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated test command verbosity settings for GPU-related test runs.
    • Adjusted copyright attribution text in the test script.

Walkthrough

The CI test script updates its SPDX attribution and adjusts pytest verbosity flags in two cudf-polars/polars test invocations.

Changes

CI test script updates

Layer / File(s) Summary
Pytest command adjustments
ci/run_cudf_polars_polars_tests.sh
The script updates the SPDX line, removes -vv from the first pytest call, and adds -v to the second pytest call.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22543: Also changes ci/run_cudf_polars_polars_tests.sh by adjusting pytest command-line flags in the cudf-polars/polars test runs.
  • rapidsai/cudf#22768: Also modifies ci/run_cudf_polars_polars_tests.sh by changing verbosity-related pytest arguments.

Suggested labels

cudf-polars

Suggested reviewers

  • jameslamb
  • vyasr
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adjusting pytest verbosity for cudf-polars Polars tests.
Description check ✅ Passed The description matches the change and explains the differing verbosity for in-memory and SPMD test runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

/merge

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

That's a strange error I haven't seen before:

FAILED test_transform.py::test_transform_udf - RuntimeError: Failed to dlopen /__w/cudf/cudf/env/lib/python3.11/site-packages/nvidia/cuda_nvrtc/lib/libnvrtc.so.12: /__w/cudf/cudf/env/lib/python3.11/site-packages/nvidia/cuda_nvrtc/lib/libnvrtc.so.12: ELF load command address/offset not page-aligned

Looking into it.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

Compared to https://github.com/rapidsai/cudf/actions/runs/28175651520/job/8345836816 (a successful run), there's no difference in packages other than libcudf/pylibcudf.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

I noticed that the build job used a different vm images commit from the test job (https://github.com/nv-gha-runners/vm-images/commit/6160e56e8f160cb5c6ec5fc49c83df2fa8daf183 vs https://github.com/nv-gha-runners/vm-images/commit/bdfd14b4c1b28580d3b2aa2c4a394344354478ae). Trying to rebuild everything to see if its resolved.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

Same errors in https://github.com/rapidsai/cudf/actions/runs/28194276461/job/83521886270?pr=22980. The associated build had the new commit.

@TomAugspurger

Copy link
Copy Markdown
Contributor Author

I removed the s (stdout) flag. Seems like the polars test suite might print quite a bit of output we don't care about.

@rapids-bot
rapids-bot Bot merged commit 5965fc8 into NVIDIA:main Jun 26, 2026
136 checks passed
copy-pr-bot Bot pushed a commit that referenced this pull request Jun 29, 2026
We run upstream polars tests with cudf-polars using two of or engines: in-memory and SPMD.

The recent CI failures running upstream polars tests have all been in the SPMD engine, while the in-memory engine has been passing fine. This change reduces the pytest verbosity for the in-memory run (making the logs easier to scan), and increases it for the SPMD run (hopefully helping with identifying the flaky tests).

Authors:
  - Tom Augspurger (https://github.com/TomAugspurger)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)
  - Matthew Murray (https://github.com/Matt711)

URL: #22980
@coderabbitai coderabbitai Bot mentioned this pull request Jul 10, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants