Skip to content

Skip code coverage where dynamic predicates are dropped #22973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Jun 25, 2026
Merged

Skip code coverage where dynamic predicates are dropped #22973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89960d8
Add a deterministic test for dropping dynamic predicates
Matt711 Jun 24, 2026
4f76f81
skip code coverage where dyn pred are dropped
Matt711 Jun 24, 2026
3ceb789
cleanup
Matt711 Jun 24, 2026
1f5c8fa
Merge branch 'main' into imp/polars/det-dyn-pred-test
Matt711 Jun 25, 2026
0f515b8
Merge branch 'main' into imp/polars/det-dyn-pred-test
TomAugspurger Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions python/cudf_polars/cudf_polars/dsl/translate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,11 @@ def _drop_dyn_pred_hints(
):
left = _drop_dyn_pred_hints(translator, node.left, schema)
right = _drop_dyn_pred_hints(translator, node.right, schema)
if left is None:
return right # pragma: no cover
if right is None:
# Which branch is taken depends on where the dynamic predicate lands in
# the AND tree, which is nondeterministic.
if left is None: # pragma: no cover
return right
if right is None: # pragma: no cover
return left
return expr.BinOp(
DataType(translator.visitor.get_dtype(n)),
Expand Down
2 changes: 1 addition & 1 deletion python/cudf_polars/tests/test_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES.
# SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
from __future__ import annotations

Expand Down
Loading