-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Select Parquet columns by field ID #22955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 26 commits into
NVIDIA:main
from
mhaseeb123:fea/select-pq-cols-by-field-id
Jul 11, 2026
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
08f1e36
Select Parquet columns by field ID
mhaseeb123 5781078
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 4241c2d
Apply suggestion from coderabbit
mhaseeb123 4b99d07
Minor
mhaseeb123 43235a3
Style
mhaseeb123 2d26e65
Minor bug fix
mhaseeb123 3cc2e46
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 5048a45
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 d51c620
Apply partial suggestions
mhaseeb123 09e8735
Apply suggestions
mhaseeb123 b006c62
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 8d95803
style
mhaseeb123 cea7b9f
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 12eedd9
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 04a2527
Merge branch 'main' into fea/select-pq-cols-by-field-id
vyasr fe2485d
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 545b82f
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 3dfb09f
Address reviews
mhaseeb123 8417b0e
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 8073240
style
mhaseeb123 f920a00
Minor
mhaseeb123 12cf311
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 1335b4a
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 e66174a
Address comments
mhaseeb123 a18925b
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 86a4b48
Merge branch 'main' into fea/select-pq-cols-by-field-id
mhaseeb123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,37 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION. | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include "column_path_helpers.hpp" | ||
|
|
||
| #include <cudf/io/parquet_schema.hpp> | ||
|
|
||
| #include <algorithm> | ||
| #include <cctype> | ||
| #include <cstddef> | ||
| #include <functional> | ||
| #include <numeric> | ||
| #include <string> | ||
| #include <string_view> | ||
| #include <utility> | ||
| #include <vector> | ||
|
|
||
| namespace cudf::io::parquet::detail { | ||
|
|
||
| std::string column_path_from_index(std::span<SchemaElement const> schema_tree, int schema_idx) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given a |
||
| { | ||
| std::vector<std::string> path; | ||
| for (auto idx = schema_idx; idx > 0; idx = schema_tree[idx].parent_idx) { | ||
| path.push_back(schema_tree[idx].name); | ||
| } | ||
|
|
||
| return std::accumulate( | ||
| path.rbegin() + 1, path.rend(), path.back(), [](auto path_so_far, auto const& elem_name) { | ||
| return std::move(path_so_far) + "." + elem_name; | ||
| }); | ||
| } | ||
|
|
||
| std::string normalize_column_path(std::string_view col_path, bool case_sensitive_names) | ||
| { | ||
| if (case_sensitive_names) { return std::string{col_path}; } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty standard setters and getters