Test only oldest and newest supported polars versions in PR CI - #22939
Conversation
Nightly CI continues to test all versions via test.yaml. Set POLARS_VERSIONS=endpoints locally or in test.yaml to run the full matrix.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR adds ChangesPolars version endpoint filtering and CI trigger
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/test_wheel_cudf_polars.sh`:
- Around line 24-28: Add validation in the conditional block where
POLARS_VERSIONS is checked for "endpoints" to ensure the VERSIONS array contains
at least two elements before attempting to access ${VERSIONS[0]} and
${VERSIONS[-1]}. If the array has fewer than two elements, the script should
exit with a meaningful error message that explains the issue (such as "VERSIONS
array must contain at least 2 elements for endpoints comparison"), rather than
silently proceeding with potentially incorrect behavior or unclear failure
messages.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e4a96843-060d-43ca-a080-377723d24108
📒 Files selected for processing (2)
.github/workflows/pr.yamlci/test_wheel_cudf_polars.sh
| build_type: pull-request | ||
| container-options: "--cap-add CAP_SYS_PTRACE --shm-size=8g --ulimit=nofile=1000000:1000000" | ||
| script: "ci/test_wheel_cudf_polars.sh" | ||
| env: "POLARS_VERSIONS=endpoints" |
There was a problem hiding this comment.
| env: "POLARS_VERSIONS=endpoints" | |
| env: "POLARS_VERSIONS=endpoints" |
This needs to be at the same level as with, not inside of it
d20d472 to
f0afdfd
Compare
ae1d669 to
46c8567
Compare
|
/merge |
…A#22939) The polars compat test job runs the cudf-polars test suite against every supported polars version, which helps make it one of the longest running CI jobs. Since regressions are most likely to appear at the boundaries of the support matrix, restrict PR CI to only the oldest and newest supported versions. The middle versions are retained in nightly CI via test.yaml, which continues to run the full matrix. The script accepts a `POLARS_VERSIONS=endpoints` environment variable to select this mode, so the full matrix can still be run locally or in nightlies without any script changes — useful when updating polars version pins to verify the right version guards are in place. Authors: - Matthew Murray (https://github.com/Matt711) Approvers: - Gil Forsyth (https://github.com/gforsyth) - Mads R. B. Kristensen (https://github.com/madsbk) URL: NVIDIA#22939
Description
The polars compat test job runs the cudf-polars test suite against every
supported polars version, which helps make it one of the longest running CI jobs.
Since regressions are most likely to appear at the boundaries of the support
matrix, restrict PR CI to only the oldest and newest supported versions.
The middle versions are retained in nightly CI via test.yaml, which continues
to run the full matrix.
The script accepts a
POLARS_VERSIONS=endpointsenvironment variable toselect this mode, so the full matrix can still be run locally or in nightlies
without any script changes — useful when updating polars version pins to
verify the right version guards are in place.
Checklist