Skip to content

fix(artifacts): correctly label non-arch-dependent but cuda-dependent artifacts - #22902

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
gforsyth:correct_artifact_labels
Jun 16, 2026
Merged

fix(artifacts): correctly label non-arch-dependent but cuda-dependent artifacts#22902
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
gforsyth:correct_artifact_labels

Conversation

@gforsyth

Copy link
Copy Markdown
Contributor

Part of rapidsai/build-planning#270

Followup to #22327

dask-cuda and cudf-polars wheels use a cuda-suffix, so we build them per-CUDA version, but they are $ARCH-agnostic, so we should set the --arch to any so ARM runners can download artifacts built on x86_64

@gforsyth
gforsyth requested a review from a team as a code owner June 16, 2026 13:21
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 16, 2026
@gforsyth
gforsyth requested a review from msarahan June 16, 2026 13:21
@gforsyth gforsyth added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d121b7c5-260a-4b4d-8283-0b31a523dbbc

📥 Commits

Reviewing files that changed from the base of the PR and between 21c003d and 457c606.

📒 Files selected for processing (5)
  • ci/build_wheel_cudf_polars.sh
  • ci/build_wheel_dask_cudf.sh
  • ci/test_cudf_polars_polars_tests.sh
  • ci/test_wheel_cudf_polars.sh
  • ci/test_wheel_dask_cudf.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated continuous integration scripts to use architecture-agnostic specifications for wheel artifacts across Python packages and CUDA-enabled variants, improving consistency and compatibility across different system environments in the build and deployment pipeline.

Walkthrough

Five CI shell scripts for cudf-polars and dask-cudf wheel operations are updated to add --arch any to rapids-artifact-name command invocations. Two build scripts update RAPIDS_PACKAGE_NAME construction; three test scripts update their wheelhouse download artifact selection. No other build, install, or test logic changes.

Changes

Add --arch any to wheel artifact naming and download

Layer / File(s) Summary
Build-time artifact naming
ci/build_wheel_cudf_polars.sh, ci/build_wheel_dask_cudf.sh
RAPIDS_PACKAGE_NAME construction adds --arch any to the rapids-artifact-name wheel_python call in both build scripts.
Test-time wheel download selection
ci/test_wheel_cudf_polars.sh, ci/test_cudf_polars_polars_tests.sh, ci/test_wheel_dask_cudf.sh
CUDF_POLARS_WHEELHOUSE and DASK_CUDF_WHEELHOUSE download commands add --arch any to the rapids-artifact-name invocation used to resolve the artifact.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • rapidsai/cudf#22327: Refactored wheel build and download scripts to use rapids-artifact-name for artifact naming in the same ci/build_wheel_cudf_polars.sh and ci/build_wheel_dask_cudf.sh flows that this PR extends with --arch any.

Suggested labels

Python, cudf-polars

Suggested reviewers

  • msarahan
  • bdice
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: correcting artifact labels for architecture-dependent but CUDA-dependent packages by adding --arch any parameters.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for adding --arch any to artifact downloads and why it's needed for ARM runners.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jameslamb
jameslamb removed the request for review from msarahan June 16, 2026 15:09
@gforsyth

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 23d9c85 into NVIDIA:main Jun 16, 2026
379 of 384 checks passed
@gforsyth
gforsyth deleted the correct_artifact_labels branch June 16, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants