Skip to content

Add cudf_streaming to clang-format IncludeCategories - #22881

Merged
vyasr merged 2 commits into
NVIDIA:mainfrom
vyasr:add-cudf-streaming-include-category
Jun 15, 2026
Merged

Add cudf_streaming to clang-format IncludeCategories#22881
vyasr merged 2 commits into
NVIDIA:mainfrom
vyasr:add-cudf-streaming-include-category

Conversation

@vyasr

@vyasr vyasr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Add cudf_streaming to the 'other libcudf includes' regex in .clang-format so that cudf_streaming/ headers are sorted into the correct include category (priority 5) instead of falling through to the generic system includes bucket (priority 9).

Follow-up from #22747 (comment)

Add cudf_streaming to the 'other libcudf includes' regex in
.clang-format so that cudf_streaming/ headers are sorted into the
correct include category (priority 5) instead of falling through to
the generic system includes bucket.

Follow-up from NVIDIA#22747 (comment)
@vyasr
vyasr requested a review from a team as a code owner June 13, 2026 00:30
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 13, 2026
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 35731c5d-6990-4a0c-bc59-152433c5ff44

📥 Commits

Reviewing files that changed from the base of the PR and between 2547978 and 13feb87.

📒 Files selected for processing (38)
  • .clang-format
  • cpp/libcudf_streaming/benchmarks/bench_partition.cpp
  • cpp/libcudf_streaming/benchmarks/bench_shuffle.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/bench_streaming_shuffle.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/data_generator.hpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/bench_read.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/concatenate.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/groupby.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/join.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/parquet_writer.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q01.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q03.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q04.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q09.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/q21.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/sort.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/utils.cpp
  • cpp/libcudf_streaming/benchmarks/streaming/ndsh/utils.hpp
  • cpp/libcudf_streaming/examples/example_shuffle.cpp
  • cpp/libcudf_streaming/include/cudf_streaming/streaming/channel_metadata.hpp
  • cpp/libcudf_streaming/src/integrations/bloom_filter.cu
  • cpp/libcudf_streaming/src/integrations/partition.cpp
  • cpp/libcudf_streaming/src/integrations/utils.cpp
  • cpp/libcudf_streaming/src/streaming/bloom_filter.cpp
  • cpp/libcudf_streaming/src/streaming/channel_metadata.cpp
  • cpp/libcudf_streaming/src/streaming/parquet.cpp
  • cpp/libcudf_streaming/src/streaming/partition.cpp
  • cpp/libcudf_streaming/src/streaming/table_chunk.cpp
  • cpp/libcudf_streaming/tests/streaming/test_allgather.cpp
  • cpp/libcudf_streaming/tests/streaming/test_channel_metadata.cpp
  • cpp/libcudf_streaming/tests/streaming/test_leaf_actor.cpp
  • cpp/libcudf_streaming/tests/streaming/test_partition.cpp
  • cpp/libcudf_streaming/tests/streaming/test_read_parquet.cpp
  • cpp/libcudf_streaming/tests/streaming/test_shuffler.cpp
  • cpp/libcudf_streaming/tests/streaming/test_table_chunk.cpp
  • cpp/libcudf_streaming/tests/test_partition.cpp
  • cpp/libcudf_streaming/tests/test_shuffler.cpp
  • cpp/libcudf_streaming/tests/test_shuffler_many_streams.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Style

    • Reorganized include directives across benchmark and test files for consistent ordering.
    • Adjusted spacing between include sections throughout the codebase.
  • Chores

    • Updated clang-format configuration to standardize include categorization rules.

Walkthrough

Updated .clang-format to categorize cudf_streaming includes with other libcudf headers, then applied this new include ordering rule across 38 benchmark, example, source, test, and header files in the cudf_streaming module.

Changes

Include ordering for cudf_streaming

Layer / File(s) Summary
clang-format configuration and include reordering
.clang-format, cpp/libcudf_streaming/benchmarks/*, cpp/libcudf_streaming/examples/*, cpp/libcudf_streaming/include/*, cpp/libcudf_streaming/src/*, cpp/libcudf_streaming/tests/*
The .clang-format IncludeCategories pattern was extended to treat cudf_streaming as part of the "other libcudf includes" group. This triggered include reordering across 38 files: cudf_streaming headers are now consistently positioned before RMM and CUDA runtime headers, with blank-line spacing adjustments to delineate include sections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • PR addresses the include categorization handling for cudf_streaming as part of follow-up work for rapidsmpf-to-cudf migration.

Suggested labels

libcudf, improvement, non-breaking

Suggested reviewers

  • qbacpey
  • pentschev
  • galipremsagar
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: adding cudf_streaming to the clang-format IncludeCategories configuration.
Description check ✅ Passed The description clearly explains the purpose and context of the change, detailing why cudf_streaming needs to be added to the include category regex.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@vyasr

vyasr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/merge

1 similar comment
@vyasr

vyasr commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@vyasr
vyasr merged commit 24d9adc into NVIDIA:main Jun 15, 2026
134 checks passed
@vyasr
vyasr deleted the add-cudf-streaming-include-category branch June 15, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants