Skip to content

Destroy RTCX cache before teardown #22843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Jun 17, 2026
Merged

Destroy RTCX cache before teardown #22843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
750f97e
Destroy RTCX cache before teardown
fallintoplace Jun 10, 2026
9bd96e2
Merge branch 'main' into fix-rtcx-teardown-order
davidwendt Jun 11, 2026
7b8192d
Address context test review feedback
fallintoplace Jun 16, 2026
62246a0
Merge branch 'main' into fix-rtcx-teardown-order
vyasr Jun 16, 2026
a96996d
Fix style: update copyright notices and clang-format CommentPragmas
vyasr Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ BreakConstructorInitializers: BeforeColon
BreakInheritanceList: BeforeColon
BreakStringLiterals: true
ColumnLimit: 100
CommentPragmas: '^ IWYU pragma:'
CommentPragmas: '(IWYU pragma:|SPDX-)'

@vyasr vyasr Jun 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #22118 (comment) but for clang-format. We'll address this in more detail next week.

CompactNamespaces: false
ConstructorInitializerAllOnOneLineOrOnePerLine: true
# Kept the below 2 to be the same as `IndentWidth` to keep everything uniform
Expand Down
9 changes: 7 additions & 2 deletions cpp/src/runtime/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -55,7 +55,12 @@ void context::ensure_jit_cache_initialized()
});
}

context::~context() { rtcx::teardown(); }
context::~context()
{
_jit_bundle.reset();
_rtcx_cache.reset();
rtcx::teardown();
}

rtcx::cache_t& context::rtcx_cache()
{
Expand Down
30 changes: 29 additions & 1 deletion cpp/tests/utilities_tests/context_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

#include <cudf_test/base_fixture.hpp>
#include <cudf_test/column_wrapper.hpp>

#include <cudf/ast/expressions.hpp>
#include <cudf/column/column.hpp>
#include <cudf/context.hpp>
#include <cudf/table/table_view.hpp>
#include <cudf/transform.hpp>

#include <gtest/gtest.h>

Expand Down Expand Up @@ -35,6 +40,29 @@ TEST_F(ContextTest, InitializeAfterTeardown)
EXPECT_NO_THROW(cudf::initialize(cudf::init_flags::INIT_JIT_CACHE));
}

TEST_F(ContextTest, TeardownAfterJitCacheUse)
{
auto compute_column = [] {
auto c_0 = cudf::test::fixed_width_column_wrapper<cudf::size_type>{3, 20, 1, 50};
auto c_1 = cudf::test::fixed_width_column_wrapper<cudf::size_type>{10, 7, 20, 0};
auto table = cudf::table_view{{c_0, c_1}};
auto col_ref_0 = cudf::ast::column_reference(0);
auto col_ref_1 = cudf::ast::column_reference(1);
auto expression = cudf::ast::operation(cudf::ast::ast_operator::ADD, col_ref_0, col_ref_1);

auto result = cudf::compute_column_jit(table, expression);
EXPECT_EQ(result->size(), cudf::size_type{4});
};

cudf::initialize(cudf::init_flags::INIT_JIT_CACHE);
ASSERT_NO_THROW(compute_column());
EXPECT_NO_THROW(cudf::teardown());

cudf::initialize(cudf::init_flags::INIT_JIT_CACHE);
ASSERT_NO_THROW(compute_column());
EXPECT_NO_THROW(cudf::teardown());
}

TEST_F(ContextTest, TeardownWithoutInitialize) { EXPECT_NO_THROW(cudf::teardown()); }

TEST_F(ContextTest, MultipleTeardownCalls)
Expand Down
Loading