Skip to content

Temporarily WAR rapidsmpf<->libcudf conda package build cycle (#22520) #22772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolorunyomi merged 1 commit into from
Jun 3, 2026
Merged

Temporarily WAR rapidsmpf<->libcudf conda package build cycle (#22520) #22772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions conda/recipes/cudf-polars/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,16 @@ requirements:
by_name:
- cuda-version

tests:
- python:
imports:
- cudf_polars
pip_check: false
- script:
- python -c "import cudf_polars; print(cudf_polars.__version__)"
- RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)"
- CUDF_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)"
- RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; import polars as pl; print(pl.Series([1, 2, 3]))"
# tests:
# - python:
# imports:
# - cudf_polars
# pip_check: false
# - script:
# - python -c "import cudf_polars; print(cudf_polars.__version__)"
# - RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)"
# - CUDF_NO_INITIALIZE=1 python -c "import cudf_polars; print(cudf_polars.__version__)"
# - RAPIDS_NO_INITIALIZE=1 python -c "import cudf_polars; import polars as pl; print(pl.Series([1, 2, 3]))"
Comment on lines +52 to +61

@coderabbitai coderabbitai Bot Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add an explicit re-enable guard for this temporary test disable.

Commenting out the full tests block removes all package-level validation and can easily become permanent without a tracked rollback condition. Please annotate this block with a TODO + tracking issue and explicit re-enable criteria/date.

Suggested patch 
-# tests:
+# TODO(https://github.com/rapidsai/cudf/issues/<issue-id>): Temporary WAR for
+# rapidsmpf<->libcudf conda build cycle. Re-enable recipe tests by 2026-07-31
+# (or once dependency cycle is resolved) to restore package validation.
+# tests:
 #   - python:
 #       imports:
 #         - cudf_polars
 #       pip_check: false
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@conda/recipes/cudf-polars/recipe.yaml` around lines 52 - 61, The
commented-out tests block removes package validation permanently; uncomment it
and instead of leaving it fully disabled add a clear TODO guard comment above
the tests block that states why it's temporarily disabled, references a tracking
issue (e.g., "TODO: re-enable tests - see ISSUE-XXXX"), and specifies explicit
re-enable criteria or date (e.g., "re-enable after RAPIDS/CUDF init fix or by
YYYY-MM-DD"); ensure the top-level tests block name ("tests") remains present
and the TODO includes the tracking issue ID and re-enable condition so
maintainers can find and revert the temporary change.


about:
homepage: ${{ load_from_file("python/cudf_polars/pyproject.toml").project.urls.Homepage }}
Expand Down
Loading