-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Create new libcudf_streaming C++ library #22747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b408816
feat(libcudf_streaming): add CMake build system
vyasr 9f39615
feat(libcudf_streaming): add C++ headers
vyasr de9333d
feat(libcudf_streaming): add C++ source files
vyasr 7a5dc7a
feat(libcudf_streaming): add C++ tests
vyasr a84dada
feat(libcudf_streaming): add packaging
vyasr 71b73fc
feat(libcudf_kafka): use shared get_cudf.cmake
vyasr d4474e7
feat(libcudf_streaming): add CODEOWNERS for C++ code
vyasr ef1253d
Fix style
vyasr 1281ea1
chore(deps): remove unused libcudf_streaming dependency entry
vyasr 5b4e206
Add librapidsmpf to libcudf cache host deps
vyasr 0c357f9
Fetch cuco
vyasr 66eae2d
Pass CMAKE_CUDA_ARCHITECTURES to libcudf_streaming build
vyasr dcf3158
Install streaming tests via rapids_test for CI
vyasr 81b67ec
Pin librapidsmpf to minor_version in conda recipe
vyasr f1328c2
Add rapidsmpf Python package dependency for cudf_polars
vyasr 7829c8f
Add wheel build/publish CI jobs for libcudf_streaming
vyasr bbb91e2
Exclude transitive shared libs from auditwheel repair
vyasr eeee936
Make sure arches are defined
vyasr d543440
Address review feedback: fix bugs and add missing runtime dep
vyasr ac59082
Add libcudf_streaming to validate_wheel.sh allowlist
vyasr ef08ee8
Also assign cmake codeowners
vyasr c2f3ad4
Remove unnecessary dep
vyasr cc7e1b4
Address code review: fix includes, docs, and minor bugs
vyasr 168d39d
Move streaming tests after target setup
vyasr c333f2b
Add direct includes for streaming sources
vyasr 8703ae1
Clean up streaming test review feedback
vyasr ffe4429
Fix VERSION file
vyasr 7aa63ab
Set stricter timeouts
vyasr 2a22732
Sort list
vyasr aa37256
Clean up get_cudf.cmake
vyasr d3ac6cc
Hyphenate package name
vyasr 156f4ac
Merge remote-tracking branch 'upstream/main' into branch-cudf-streami…
vyasr 9532ffa
Fix symlink
vyasr 9d2feab
Address review feedback
vyasr d34574f
Use hyphenated conda package name for libcudf-streaming
vyasr 15d6c1d
Merge branch 'main' into branch-cudf-streaming-cpp
vyasr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mroeschke marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| source rapids-init-pip | ||
|
|
||
| package_name="libcudf_streaming" | ||
|
vyasr marked this conversation as resolved.
|
||
| package_dir="python/libcudf_streaming" | ||
|
|
||
| rapids-logger "Generating build requirements" | ||
|
|
||
| rapids-dependency-file-generator \ | ||
| --output requirements \ | ||
| --file-key "py_build_${package_name}" \ | ||
| --file-key "py_rapids_build_${package_name}" \ | ||
| --matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION};cuda_suffixed=true" \ | ||
| | tee /tmp/requirements-build.txt | ||
|
|
||
| rapids-logger "Installing build requirements" | ||
| rapids-pip-retry install \ | ||
| -v \ | ||
| --prefer-binary \ | ||
| -r /tmp/requirements-build.txt | ||
|
|
||
| # build with '--no-build-isolation', for better sccache hit rate | ||
| # 0 really means "add --no-build-isolation" (ref: https://github.com/pypa/pip/issues/5735) | ||
| export PIP_NO_BUILD_ISOLATION=0 | ||
|
|
||
| ./ci/build_wheel.sh "${package_name}" "${package_dir}" | ||
|
|
||
| # repair wheels and write to the location that artifact-uploading code expects to find them | ||
| python -m auditwheel repair \ | ||
| --exclude libcudf.so \ | ||
| --exclude librapidsmpf.so \ | ||
| --exclude librapids_logger.so \ | ||
| --exclude librmm.so \ | ||
| --exclude libucxx.so \ | ||
| --exclude libucp.so.0 \ | ||
| -w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \ | ||
| ${package_dir}/dist/* | ||
|
|
||
| ./ci/validate_wheel.sh "${package_dir}" "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/bin/bash | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # Support customizing the ctests' install location | ||
| # First, try the installed location (CI/conda environments) | ||
| installed_test_location="${INSTALL_PREFIX:-${CONDA_PREFIX:-/usr}}/bin/gtests/libcudf_streaming/" | ||
| # Fall back to the build directory (devcontainer environments) | ||
| script_dir="$(dirname "$(realpath "${BASH_SOURCE[0]}")")" | ||
| devcontainers_test_location="${script_dir}/../cpp/libcudf_streaming/build/latest" | ||
| buildsh_test_location="${STREAMING_LIB_BUILD_DIR:-${script_dir}/../cpp/libcudf_streaming/build}" | ||
|
|
||
| if [[ -d "${installed_test_location}" ]]; then | ||
| cd "${installed_test_location}" | ||
| elif [[ -d "${devcontainers_test_location}" ]]; then | ||
| cd "${devcontainers_test_location}" | ||
| elif [[ -d "${buildsh_test_location}" ]]; then | ||
| cd "${buildsh_test_location}" | ||
| else | ||
| echo "Error: Test location not found. Searched:" >&2 | ||
| echo " - ${installed_test_location}" >&2 | ||
| echo " - ${devcontainers_test_location}" >&2 | ||
| echo " - ${buildsh_test_location}" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| ctest --output-on-failure --no-tests=error "$@" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.