Skip to content

Add noinline to n_table_comparator::operator() #22699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
May 28, 2026
Merged

Add noinline to n_table_comparator::operator() #22699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cpp/src/groupby/streaming_groupby/common.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,7 @@ struct n_table_comparator {
key_location_t const* key_loc; ///< {batch_id, row_in_compacted} per dense ID
size_type max_distinct_keys; ///< Threshold: idx >= max_distinct_keys is a transient batch value

#ifndef NDEBUG
__attribute__((noinline))
#endif
__device__ bool
operator()(size_type lhs, size_type rhs) const noexcept
__attribute__((noinline)) __device__ bool operator()(size_type lhs, size_type rhs) const noexcept
{
bool const lhs_is_batch = (lhs >= max_distinct_keys);
bool const rhs_is_batch = (rhs >= max_distinct_keys);
Expand Down
Loading