Skip to content

Drop caveat about strict channel priority - #22688

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jakirkham:fix_doc_strict_priority
May 28, 2026
Merged

Drop caveat about strict channel priority#22688
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
jakirkham:fix_doc_strict_priority

Conversation

@jakirkham

Copy link
Copy Markdown
Contributor

Strict channel priority has been working with RAPIDS since 25.04 (over a year). So this caveat about using flexible channel priority no longer applies. Given this, drop the comment.

Fixes #22687

@jakirkham jakirkham added doc Documentation non-breaking Non-breaking change labels May 27, 2026
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6acc3b65-1d84-4d31-b2d0-a579b1012099

📥 Commits

Reviewing files that changed from the base of the PR and between 2d4cc67 and f9682c5.

📒 Files selected for processing (1)
  • CONTRIBUTING.md
💤 Files with no reviewable changes (1)
  • CONTRIBUTING.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Simplified conda environment setup instructions by removing a technical constraint note.

Walkthrough

This PR removes an outdated documentation note from CONTRIBUTING.md that warned against using conda channel_priority: strict. The note is no longer accurate, as strict channel priority support has been available since RAPIDS 25.04.

Changes

Conda strict channel priority documentation update

Layer / File(s) Summary
Remove outdated conda strict channel priority note
CONTRIBUTING.md
Deleted the discouragment against using channel_priority: strict from the conda environment-creation instructions, reflecting that this feature is now supported.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change—removing a documentation caveat about strict channel priority.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for removing the caveat and referencing the linked issue.
Linked Issues check ✅ Passed The PR directly addresses issue #22687 by removing the outdated documentation caveat about strict channel priority no longer being supported.
Out of Scope Changes check ✅ Passed The changes are limited to removing the specific caveat mentioned in the linked issue; no unrelated or out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jakirkham

Copy link
Copy Markdown
Contributor Author

CI failures are unrelated to this simple doc change

That said, they should be fixed by PR: #22677

As those fixes recently merged into main, merging in the latest changes from main should resolve them. So doing that now

@jakirkham

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 93b0d79 into NVIDIA:main May 28, 2026
73 checks passed
@jakirkham
jakirkham deleted the fix_doc_strict_priority branch May 28, 2026 04:10
@jakirkham

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing Bradley! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Documentation non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Update docs to reflect Conda strict channel priority support

2 participants