Minimize Ray resource acquisition in cudf_polars tests - #22661
Merged
rapids-bot[bot] merged 9 commits intoMay 28, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRefactors Ray test setup to use session-scoped ChangesRay Engine Configuration Parameterization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
TomAugspurger
approved these changes
May 26, 2026
madsbk
requested changes
May 27, 2026
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
wence-
approved these changes
May 28, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #22646 in approach to minimize Ray resource spin-up in cudf_polars tests
test_scan,test_filter,test_group_by,test_join, andtest_empty_dataframeas they already have coverage in other test where we parameterize over engineray_init_optionsfixture for initializationnum_cpusset to 2 instead of auto-detecting virtual coresnum_gpusset to 0 (IIUC this detection is only needed by the workers)include_dashboardalwaysFalseobject_store_memoryset to 256 MB instead ofmin(0.3 * system memory, 200GB)Checklist