Remove deprecated nvtext::edit_distance_matrix - #22644
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR removes the deprecated edit_distance_matrix API across C++ headers/implementation, Python accessors, and Cython bindings, refactors the C++ device compute to a diagonal/tiled algorithm for edit_distance, and updates documentation accordingly. ChangesDeprecation Removal: edit_distance_matrix
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
igorpeshansky
left a comment
There was a problem hiding this comment.
Mostly LGTM, with one optional style nit.
|
Actionable comments posted: 0 |
|
/merge |
* After #22644, we no longer need to filter a `FutureWarning` from Python doctests * Ensures testing utility function is seeded aligning with all random data generation * Follow up to #22645, ensures the `ThreadPoolExecutor` in `conftest.py` is eventually shut down Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #22713
Description
Removes the
nvtext::edit_distance_matrix()API and pylibcudf and python equivalents deprecated in 26.04.Checklist