Skip to content

Remove deprecated nvtext::edit_distance_matrix - #22644

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
davidwendt:del-edit-dist2
May 29, 2026
Merged

Remove deprecated nvtext::edit_distance_matrix#22644
rapids-bot[bot] merged 3 commits into
NVIDIA:mainfrom
davidwendt:del-edit-dist2

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Removes the nvtext::edit_distance_matrix() API and pylibcudf and python equivalents deprecated in 26.04.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this May 22, 2026
@davidwendt davidwendt added the 3 - Ready for Review Ready for review by team label May 22, 2026
@davidwendt
davidwendt requested review from a team as code owners May 22, 2026 18:27
@davidwendt davidwendt added libcudf Affects libcudf (C++/CUDA) code. breaking Breaking change labels May 22, 2026
@davidwendt davidwendt added the non-breaking Non-breaking change label May 22, 2026
@github-actions github-actions Bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels May 22, 2026
@GPUtester GPUtester moved this to In Progress in cuDF Python May 22, 2026
@davidwendt davidwendt added improvement Improvement / enhancement to an existing function and removed non-breaking Non-breaking change labels May 22, 2026
@coderabbitai

coderabbitai Bot commented May 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6fccb1a5-d546-46ae-802a-9472c64c4bcf

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5307b and 8f973f7.

📒 Files selected for processing (2)
  • docs/cudf/source/cudf/api_docs/series.rst
  • python/pylibcudf/pylibcudf/nvtext/edit_distance.pyx
💤 Files with no reviewable changes (1)
  • docs/cudf/source/cudf/api_docs/series.rst
🚧 Files skipped from review as they are similar to previous changes (1)
  • python/pylibcudf/pylibcudf/nvtext/edit_distance.pyx

📝 Walkthrough

Summary by CodeRabbit

  • Breaking Changes

    • Removed the deprecated edit_distance_matrix method from all public interfaces; migrate to edit_distance for string distance operations.
  • Documentation

    • API docs updated to remove references to the deprecated method.

Walkthrough

The PR removes the deprecated edit_distance_matrix API across C++ headers/implementation, Python accessors, and Cython bindings, refactors the C++ device compute to a diagonal/tiled algorithm for edit_distance, and updates documentation accordingly.

Changes

Deprecation Removal: edit_distance_matrix

Layer / File(s) Summary
C++ API removal and compute refactor
cpp/include/nvtext/edit_distance.hpp, cpp/src/text/edit_distance.cu
C++ header removes the deprecated edit_distance_matrix declaration. Implementation replaces prior 2-row device compute with a tiled/diagonal compute_distance, removes matrix-specific kernel/buffer logic and the public edit_distance_matrix forwarder, and retains edit_distance API.
Python accessor method removal
python/cudf/cudf/core/accessors/string.py, python/cudf/cudf/core/column/string.py
StringMethods and StringColumn remove deprecated edit_distance_matrix methods (including FutureWarning and libcudf call); module warnings import cleaned up.
Cython binding and type stub updates
python/pylibcudf/pylibcudf/libcudf/nvtext/edit_distance.pxd, python/pylibcudf/pylibcudf/nvtext/edit_distance.pxd, python/pylibcudf/pylibcudf/nvtext/edit_distance.pyx, python/pylibcudf/pylibcudf/nvtext/edit_distance.pyi
Cython externs and type stubs remove edit_distance_matrix and expose only edit_distance. edit_distance extern now includes explicit stream and device_async_resource_ref mr parameters and exception handling; __all__ updated.
API documentation removal
docs/cudf/source/cudf/api_docs/series.rst
Series.str autosummary no longer lists edit_distance_matrix.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove deprecated nvtext::edit_distance_matrix' directly and clearly describes the main change: removal of a deprecated API across the codebase.
Description check ✅ Passed The description explicitly states that the PR removes the nvtext::edit_distance_matrix() API and its equivalents, which aligns with the changeset modifications across header files, CUDA implementation, documentation, and Python bindings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@davidwendt davidwendt added non-breaking Non-breaking change breaking Breaking change and removed breaking Breaking change non-breaking Non-breaking change labels May 22, 2026

@igorpeshansky igorpeshansky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, with one optional style nit.

Comment thread python/pylibcudf/pylibcudf/nvtext/edit_distance.pyx Outdated
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@davidwendt

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 7b802c7 into NVIDIA:main May 29, 2026
219 of 221 checks passed
@davidwendt
davidwendt deleted the del-edit-dist2 branch May 29, 2026 16:46
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 29, 2026
rapids-bot Bot pushed a commit that referenced this pull request May 30, 2026
* After #22644, we no longer need to filter a `FutureWarning` from Python doctests
* Ensures testing utility function is seeded aligning with all random data generation
* Follow up to #22645, ensures the `ThreadPoolExecutor` in `conftest.py` is eventually shut down

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #22713
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants