Skip to content

Fix memcheck error in json checked-token-level utility #22571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 1 commit into from
May 19, 2026
Merged

Fix memcheck error in json checked-token-level utility #22571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cpp/src/io/json/json_tree.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ struct is_nested_end {
};

struct checked_token_level_output {
bool* depth_out_of_range;
int32_t* depth_out_of_range;

__device__ TreeDepthT operator()(size_type level) const
{
static_assert(sizeof(TreeDepthT) < sizeof(size_type));
if (level < static_cast<size_type>(cuda::std::numeric_limits<TreeDepthT>::min()) ||
level > static_cast<size_type>(cuda::std::numeric_limits<TreeDepthT>::max())) {
cuda::atomic_ref<bool, cuda::thread_scope_device> flag{*depth_out_of_range};
cuda::atomic_ref<int32_t, cuda::thread_scope_device> flag{*depth_out_of_range};
if (!flag.load(cuda::std::memory_order_relaxed)) {
flag.store(true, cuda::std::memory_order_relaxed);
}
Expand Down Expand Up @@ -302,7 +302,7 @@ tree_meta_t get_tree_representation(device_span<PdaTokenT const> tokens,
return does_push(token) - does_pop(token);
}));
auto depth_out_of_range =
cudf::detail::device_scalar<bool>(false, stream, cudf::get_current_device_resource_ref());
cudf::detail::device_scalar<int32_t>(0, stream, cudf::get_current_device_resource_ref());
auto const token_level_output_it = thrust::make_transform_output_iterator(
token_levels.begin(), checked_token_level_output{depth_out_of_range.data()});
thrust::exclusive_scan(rmm::exec_policy_nosync(stream, cudf::get_current_device_resource_ref()),
Expand Down
Loading