-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Transcode parquet to cuDF dictionaries for flat STRING columns #22532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
97c46d8
Add basics
mhaseeb123 a9bb221
Add basic test
mhaseeb123 b3a108e
Remaining infrastructure
mhaseeb123 040cb9f
Code cleanup
mhaseeb123 98ebabc
Minor changes
y2kiran 1b5ea78
Added list test
y2kiran 428c111
Cleanup prepare
y2kiran 139d989
Added return value for prepare
y2kiran 2c7f069
Feedback
y2kiran 58cd231
Change assemble_dict_transcoded_columns to build per-chunk column_view
y2kiran d57d70f
Parquet dictionary benchmark
y2kiran 3065d70
Added more documentation
y2kiran 629b36d
Removed uinnecessary synchronization
y2kiran 83ed466
Added fallback to STRING for AST filters
y2kiran 681a226
Added new tests
y2kiran 48458b1
Added UTF-8 characters to test
y2kiran 1eb6a25
Added more edge case tests
y2kiran 744e7e5
Formatting and licenses
y2kiran 44225bd
MR feedback
y2kiran 2a1ea2d
More bug fixes
y2kiran d063325
Formatting fixes
y2kiran b444c7b
Refined parquet benchmark
y2kiran cb65d0e
Added table to bench output
y2kiran 1fcf4ab
Modified sweep in benchmark
y2kiran 2c204d0
Fix mangled rebase
y2kiran be085f7
Test changes
y2kiran c8916e2
test signing
y2kiran 6225118
Minor fixes
y2kiran e9db447
Trimmed dead code
y2kiran 43be5c2
Cleanup
y2kiran c56e6ea
More MR feedback
y2kiran 378c97b
More MR feedback
y2kiran e3fd96b
Batched memset for nullables
y2kiran 00320a4
Cleanup
y2kiran 822c500
Formatting fixes
y2kiran 158d4a2
Helpder and code reuse
y2kiran 2e05735
Build fixes
y2kiran 176e95a
Fixed EMPTY DICT test
y2kiran 238992b
Removed benchmark file
y2kiran 6b7e3fe
Added fallback for single row gorup path
y2kiran 3802349
More cleanup
y2kiran a435cda
Bug fix
y2kiran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should instead be an issue