Guarantee insert_finished() on bulk AllGather - #22516
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesAllGather Error Handling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
insert_finished() is called after all gathering statisticsinsert_finished() on bulk AllGather
|
/merge |
|
Probably good to retarget to release/26.06 |
31ddf34 to
a4b6e2f
Compare
|
This PR's base branch has been changed since the last |
|
/merge |
Need to make sure `insert_finished` is called for collective operations. Authors: - Matthew Murray (https://github.com/Matt711) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Mads R. B. Kristensen (https://github.com/madsbk) - Lawrence Mitchell (https://github.com/wence-) URL: NVIDIA#22516
In cudf_polars we often have to use a `finally: AllGather.insert_finished()` pattern to ensure that method is called after `AllGather.insert` e.g. NVIDIA/cudf#22516. This PR defines `.__enter/exit__` like we do on `Context` to simplify this convention when we need to call `AllGather.insert` Authors: - Matthew Roeschke (https://github.com/mroeschke) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Matthew Murray (https://github.com/Matt711) - Peter Andreas Entschev (https://github.com/pentschev) - Lawrence Mitchell (https://github.com/wence-) URL: #1043
Description
Need to make sure
insert_finishedis called for collective operations.Checklist