Skip to content

Add pinned_max_pool_size and unbounded_file_read_cache to StreamingOptions - #22501

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
madsbk:add-missing-rapidsmpf-options
May 16, 2026
Merged

Add pinned_max_pool_size and unbounded_file_read_cache to StreamingOptions#22501
rapids-bot[bot] merged 1 commit into
NVIDIA:release/26.06from
madsbk:add-missing-rapidsmpf-options

Conversation

@madsbk

@madsbk madsbk commented May 14, 2026

Copy link
Copy Markdown
Contributor

Description

  • Expose two RapidsMPF options:
    • pinned_max_pool_size (RAPIDSMPF_PINNED_MAX_POOL_SIZE)
    • unbounded_file_read_cache (RAPIDSMPF_UNBOUNDED_FILE_READ_CACHE)

@madsbk madsbk self-assigned this May 14, 2026
@madsbk madsbk added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 14, 2026
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels May 14, 2026
@madsbk
madsbk force-pushed the add-missing-rapidsmpf-options branch from 0a83f95 to d33b398 Compare May 14, 2026 10:53
@GPUtester GPUtester moved this to In Progress in cuDF Python May 14, 2026
@madsbk
madsbk marked this pull request as ready for review May 15, 2026 11:39
@madsbk
madsbk requested a review from a team as a code owner May 15, 2026 11:40
@madsbk
madsbk requested a review from Matt711 May 15, 2026 11:40
@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot May 15, 2026
@coderabbitai

coderabbitai Bot commented May 15, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a5c7769a-0360-48a6-a392-d1f0a28c9cce

📥 Commits

Reviewing files that changed from the base of the PR and between 9a85bda and d33b398.

📒 Files selected for processing (2)
  • python/cudf_polars/cudf_polars/experimental/rapidsmpf/frontend/options.py
  • python/cudf_polars/tests/experimental/test_options.py

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added two new RapidsMPF configuration parameters: pinned-max-pool-size and unbounded-file-read-cache
    • Both parameters are now configurable via command-line arguments and environment variables
    • Parameters default to unspecified when not explicitly provided
  • Tests

    • Added test coverage for new configuration options and environment variable support

Walkthrough

Added pinned_max_pool_size and unbounded_file_read_cache configuration fields to StreamingOptions with environment variable support, CLI argument wiring, and test coverage for serialization, env var resolution, and argparse parsing.

Changes

RapidsMPF Configuration Fields Addition

Layer / File(s) Summary
Field definitions and CLI wiring
python/cudf_polars/cudf_polars/experimental/rapidsmpf/frontend/options.py
Extended StreamingOptions dataclass with pinned_max_pool_size and unbounded_file_read_cache fields, added docstrings documenting env vars and defaults, updated _from_argparse to extract these fields from the CLI namespace, and added --pinned-max-pool-size and --unbounded-file-read-cache CLI argument definitions.
Test coverage for new configuration fields
python/cudf_polars/tests/experimental/test_options.py
Updated serialization test to include the new fields and added tests for environment variable resolution (RAPIDSMPF_PINNED_MAX_POOL_SIZE and RAPIDSMPF_UNBOUNDED_FILE_READ_CACHE), and extended CLI roundtrip test to verify argparse integration of the new arguments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: adding two new configuration options to StreamingOptions.
Description check ✅ Passed The description is directly related to the changeset, explaining which RapidsMPF options are being exposed and their corresponding environment variables.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Comment @coderabbitai help to get the list of available commands and usage tips.

@madsbk
madsbk changed the base branch from main to release/26.06 May 16, 2026 06:17
@madsbk

madsbk commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 2de8754 into NVIDIA:release/26.06 May 16, 2026
98 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in cuDF Python May 16, 2026
@madsbk
madsbk deleted the add-missing-rapidsmpf-options branch May 16, 2026 06:18
madsbk added a commit to madsbk/cudf that referenced this pull request May 19, 2026
…ingOptions` (NVIDIA#22501)

- Expose two RapidsMPF options:
  - `pinned_max_pool_size` (`RAPIDSMPF_PINNED_MAX_POOL_SIZE`)
  - `unbounded_file_read_cache` (`RAPIDSMPF_UNBOUNDED_FILE_READ_CACHE`)

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Tom Augspurger (https://github.com/TomAugspurger)

URL: NVIDIA#22501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cudf-polars Issues specific to cudf-polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants