Consolidate evaluate_rapidsmpf into evaluate_streaming in cudf_polars - #22417
Merged
rapids-bot[bot] merged 4 commits intoMay 11, 2026
Merged
Conversation
📝 WalkthroughWalkthroughThis PR inlines RapidsMPF logical-plan evaluation into ChangesCode Simplification
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/cudf_polars/cudf_polars/experimental/parallel.py`:
- Around line 125-128: The import of evaluate_logical_plan must be moved into
the evaluate_streaming function and wrapped in a try/except that raises a clear
user-facing ImportError if rapidsmpf is missing; inside evaluate_streaming
(before calling evaluate_logical_plan(ir, config_options,
collect_metadata=False)) call _clear_source_info_cache(), then try to import
from cudf_polars.experimental.rapidsmpf.core; on ImportError raise a message
like "The streaming executor requires the 'rapidsmpf' package. Install it or
choose a different executor." and otherwise call evaluate_logical_plan and
return its result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3caedbaf-0d3a-4363-9233-88f2968a792d
📒 Files selected for processing (2)
python/cudf_polars/cudf_polars/experimental/expressions.pypython/cudf_polars/cudf_polars/experimental/parallel.py
madsbk
approved these changes
May 8, 2026
jameslamb
approved these changes
May 8, 2026
pentschev
approved these changes
May 11, 2026
Contributor
Author
|
/merge |
Merged
3 tasks
shrshi
pushed a commit
to shrshi/cudf
that referenced
this pull request
May 12, 2026
…lars (NVIDIA#22417) * Address the follow up review NVIDIA#22281 (comment) > In a followup we should merge evaluate_rapidsmpf and evaluate_streaming... * Removes a temporary iterable in `select` that I had from a leftover branch * Removes the `devcontainers` key in `dependencies.yml` that was leftover from troubleshooting the devcontainer CI job Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) - James Lamb (https://github.com/jameslamb) - Peter Andreas Entschev (https://github.com/pentschev) URL: NVIDIA#22417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
selectthat I had from a leftover branchdevcontainerskey independencies.ymlthat was leftover from troubleshooting the devcontainer CI jobChecklist