-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make RapidsMPF the default runtime for cudf_polars streaming executor #22281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
90653a9
23c5ed5
4c0a86b
e6aeb4d
fa737fe
4f90aad
71e1ca9
a5cba7a
577314c
4a37ee2
3e4dfe0
7195f5f
49849d0
4831c3f
a84a1d0
bc92082
abe246f
eb19596
4b202d0
d535356
1137bc2
a0228dc
3415749
158d0a0
0aa93c5
264f641
feb2474
d3a2e79
dcbe494
8acb2c9
2f5436f
1e19d2c
125de67
03ed9a5
29dba7e
d390d51
c550b06
0bb226f
e0e635a
dfd7b6a
29b2527
6746ab5
487e28c
2fc0975
11895e1
6455625
e4c27ef
405d012
a84cd04
14e0545
c0adafe
d9d3375
5ea9e8c
5093c79
b8cd7c4
d481460
965884e
2f03ba6
fe43ff3
3679280
b3a12db
0a5be84
c69e2d8
6b43470
c94c90b
22a6a6f
fd529e2
7a7b271
57b92fb
de4ade6
126bdc9
e062e80
02d33f4
85af11b
4d07468
46b607e
5afc788
02ba87d
12fa676
833e5c7
4d60df4
38e890e
0646bb4
7a90931
2c5dc92
fe5502b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -819,11 +819,13 @@ def read_csv_header( | |
| # TODO: Nested column names | ||
| names = chunk.column_names(include_children=False) | ||
| concatenated_columns = chunk.tbl.columns() | ||
| while reader.has_next(): | ||
| while reader.has_next(): # pragma: no cover | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sign posting: We try to see where we can add code coverage back.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes definitely, when revisiting #22346, I'm hoping we'll gain a lot of this coverage back |
||
| columns = reader.read_chunk().tbl.columns() | ||
| # Discard columns while concatenating to reduce memory footprint. | ||
| # Reverse order to avoid O(n^2) list popping cost. | ||
| for i in range(len(concatenated_columns) - 1, -1, -1): | ||
| for i in range( # pragma: no cover | ||
| len(concatenated_columns) - 1, -1, -1 | ||
| ): | ||
| concatenated_columns[i] = plc.concatenate.concatenate( | ||
| [concatenated_columns[i], columns.pop()], stream=stream | ||
| ) | ||
|
|
@@ -840,7 +842,7 @@ def read_csv_header( | |
| num_rows=num_rows, | ||
| ) | ||
| if include_file_paths is not None: | ||
| df = Scan.add_file_paths( | ||
| df = Scan.add_file_paths( # pragma: no cover | ||
| include_file_paths, paths, chunk.num_rows_per_source, df | ||
| ) | ||
| else: | ||
|
|
@@ -1164,7 +1166,7 @@ def _write_parquet( | |
| | plc.io.parquet.ParquetWriterOptionsBuilder | ||
| ) | ||
|
|
||
| if ( | ||
| if ( # pragma: no cover | ||
| parquet_options.chunked | ||
| and parquet_options.n_output_chunks != 1 | ||
| and df.table.num_rows() != 0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to call rapids-generate-scripts. I am not sure if build-all will do everything unless the scripts were regenerated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I added it, but in fe5502b I can't tell if it materially made a difference