Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,7 @@ add_library(
src/aggregation/result_cache.cpp
src/ast/expression_parser.cpp
src/ast/expressions.cpp
src/ast/jit_expressions.cpp
src/ast/operators.cpp
src/binaryop/binaryop.cpp
src/binaryop/compiled/ATan2.cu
Expand Down
7 changes: 0 additions & 7 deletions cpp/include/cudf/ast/detail/operator_functor.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -778,12 +778,5 @@ struct operator_functor<ast_operator::NULL_LOGICAL_OR, true> {
}
};

constexpr bool flatten_predicate(possibly_null_value_t<bool, false> value) { return value; }

constexpr bool flatten_predicate(possibly_null_value_t<bool, true> value)
{
return value.has_value() && *value;
}

} // namespace ast::detail
} // namespace CUDF_EXPORT cudf
8 changes: 4 additions & 4 deletions cpp/include/cudf/ast/expressions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class expression_transformer;
* This class is a part of a "visitor" pattern with the `expression_parser` class.
* Expressions inheriting from this class can accept parsers as visitors.
*/
struct expression {
struct [[nodiscard]] expression {
/**
* @brief Accepts a visitor class.
*
Expand Down Expand Up @@ -514,17 +514,17 @@ class operation : public expression {

namespace detail {

/// @brief An expression that represents a filter predicate.
/// @brief An expression that represents a predicate.
///
/// This is an internal expression used in filter operations. It is not intended to be used by
/// external code and is not a part of the public API.
class filter_predicate : public expression {
class predicate : public expression {
public:
/**
* @brief Construct a new filter predicate object
* @param source The source expression from which the predicate value is taken
*/
filter_predicate(expression const& source) : source_{source} {}
predicate(expression const& source) : source_{source} {}

/**
* @copydoc expression::accept
Expand Down
Loading
Loading