Define pandas and polars compatibility testing versions in dependencies.yaml #22189
+186
−52
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Extract matrix dimension values for a file key from dependencies.yaml.""" | ||
|
|
||
| import argparse | ||
|
|
||
| import yaml | ||
|
|
||
|
|
||
| def get_matrix_values( | ||
| deps_yaml_path: str, file_key: str, matrix_var: str | ||
| ) -> list[str]: | ||
| with open(deps_yaml_path) as f: | ||
| deps = yaml.safe_load(f) | ||
|
|
||
| file_cfg = deps.get("files", {}).get(file_key) | ||
| if file_cfg is None: | ||
| raise RuntimeError( | ||
| f"File key '{file_key}' not found in {deps_yaml_path}" | ||
| ) | ||
|
|
||
| matrix = file_cfg.get("matrix", {}) | ||
| values = matrix.get(matrix_var) | ||
| if values is None: | ||
| raise RuntimeError( | ||
| f"Matrix variable '{matrix_var}' not found in file key '{file_key}'" | ||
| ) | ||
|
|
||
| return [str(v) for v in values] | ||
|
Comment on lines
+24
to
+30
There was a problem hiding this comment. Validate matrix value type before iterating. On Line 30, a scalar YAML value would be iterated as characters and silently produce invalid output. Fail fast unless the matrix value is a sequence. Suggested patch- values = matrix.get(matrix_var)
+ values = matrix.get(matrix_var)
if values is None:
raise RuntimeError(
f"Matrix variable '{matrix_var}' not found in file key '{file_key}'"
)
+ if not isinstance(values, (list, tuple)):
+ raise RuntimeError(
+ f"Matrix variable '{matrix_var}' in file key '{file_key}' must be a list"
+ )
return [str(v) for v in values]🤖 Prompt for AI Agents |
||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser( | ||
| description="Extract matrix dimension values for a file key in dependencies.yaml" | ||
| ) | ||
| parser.add_argument("deps_yaml", help="Path to dependencies.yaml") | ||
| parser.add_argument("file_key", help="File key in the 'files' section") | ||
| parser.add_argument("matrix_var", help="Matrix variable name to extract") | ||
| args = parser.parse_args() | ||
|
|
||
| values = get_matrix_values(args.deps_yaml, args.file_key, args.matrix_var) | ||
| print(" ".join(values)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an explicit GPU preflight check before running compat tests.
This loop assumes CUDA/GPU availability but never verifies it before invoking pytest. Add a fail-fast guard (e.g.,
nvidia-smi -L) to produce a clear CI error.Suggested patch
if version_lte "${RAPIDS_PY_VERSION}" "3.13"; then + if ! nvidia-smi -L >/dev/null 2>&1; then + rapids-logger "GPU not detected; cannot run cudf.pandas compatibility tests" + exit 1 + fi for version in "${versions[@]}"; do📝 Committable suggestion
🧰 Tools
🪛 Shellcheck (0.11.0)
[info] 108-108: Not following: ./bin/activate was not specified as input (see shellcheck -x).
(SC1091)
🤖 Prompt for AI Agents