Remove CSV reader warnings emitted in unit tests - #21794
Merged
Merged
Conversation
added 2 commits
March 13, 2026 18:22
vuule
added
improvement
vuule
changed the title
Contributor
Author
|
/ok to test 306dbd0 |
pmattione-nvidia
approved these changes
Mar 16, 2026
davidwendt
approved these changes
Mar 16, 2026
davidwendt
left a comment
davidwendt
left a comment
Contributor
There was a problem hiding this comment.
Would still love for these to go away too if possible
#17827
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CSV reader has an option to deduce the compression type from the file extension (default compression option,
AUTO). However, many tests pass the default compression type when reading for a host buffer. The reader cannot determine the compression type, assumes uncompressed, and emits a warning.We don't want the noise of these warnings in the unit tests, so this PR specifies the compression type when not reading from a file.
Checklist