Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cpp/include/cudf/ast/detail/expression_evaluator.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2021-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -232,9 +232,6 @@ struct expression_evaluator {
* @param left View of the left table view used for evaluation.
* @param right View of the right table view used for evaluation.
* @param plan The collection of device references representing the expression to evaluate.
* @param thread_intermediate_storage Pointer to this thread's portion of shared memory for
* storing intermediates.

*/
__device__ inline expression_evaluator(table_device_view const& left,
table_device_view const& right,
Expand All @@ -248,8 +245,6 @@ struct expression_evaluator {
*
* @param table View of the table view used for evaluation.
* @param plan The collection of device references representing the expression to evaluate.
* @param thread_intermediate_storage Pointer to this thread's portion of shared memory for
* storing intermediates.
*/
__device__ inline expression_evaluator(table_device_view const& table,
expression_device_view const& plan)
Expand All @@ -266,8 +261,10 @@ struct expression_evaluator {
*
* @tparam Element Type of element to return.
* @tparam has_nulls Whether or not the result data is nullable.
* @param device_data_reference Data reference to resolve.
* @param row_index Row index of data column.
* @param input_reference Data reference to resolve.
* @param thread_intermediate_storage Thread-local storage for intermediate expression results.
* @param left_row_index Row index into the left table.
* @param right_row_index Row index into the right table.
* @return Element The type- and null-resolved data.
*/
template <typename Element, CUDF_ENABLE_IF(column_device_view::has_element_accessor<Element>())>
Expand Down Expand Up @@ -462,6 +459,7 @@ struct expression_evaluator {
*
* @param output_object The container that data will be inserted into.
* @param row_index Row index of all input and output data column(s).
* @param thread_intermediate_storage Thread-local storage for intermediate expression results
*/
template <typename ResultSubclass, typename T, bool result_has_nulls>
__device__ __forceinline__ void evaluate(
Expand All @@ -483,6 +481,7 @@ struct expression_evaluator {
* @param left_row_index The row to pull the data from the left table.
* @param right_row_index The row to pull the data from the right table.
* @param output_row_index The row in the output to insert the result.
* @param thread_intermediate_storage Thread-local storage for intermediate expression results
*/
template <typename ResultSubclass, typename T, bool result_has_nulls>
__device__ __forceinline__ void evaluate(
Expand Down Expand Up @@ -592,6 +591,7 @@ struct expression_evaluator {
* @param output_object The container that data will be inserted into.
* @param device_data_reference Data reference to resolve.
* @param row_index Row index of data column.
* @param thread_intermediate_storage Thread-local storage for intermediate expression results
* @param result Value to assign to output.
*/
template <typename Element,
Expand Down
8 changes: 7 additions & 1 deletion cpp/include/cudf/ast/detail/expression_parser.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -98,6 +98,9 @@ class expression_parser {
* @param expr The expression to create an evaluable expression_parser for.
* @param left The left table used for evaluating the abstract syntax tree.
* @param right The right table used for evaluating the abstract syntax tree.
* @param has_nulls Whether any of the input columns contain nulls
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource used to allocate the returned device memory
*/
expression_parser(expression const& expr,
cudf::table_view const& left,
Expand All @@ -111,6 +114,9 @@ class expression_parser {
*
* @param expr The expression to create an evaluable expression_parser for.
* @param table The table used for evaluating the abstract syntax tree.
* @param has_nulls Whether any of the input columns contain nulls
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource used to allocate the returned device memory
*/
expression_parser(expression const& expr,
cudf::table_view const& table,
Expand Down
3 changes: 1 addition & 2 deletions cpp/include/cudf/detail/algorithms/reduce.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ namespace cudf::detail {
* @param begin Device-accessible iterator to start of input values
* @param end Device-accessible iterator to end of input values
* @param init Initial value for the reduction
* @param op Binary reduction operator
* @param binary_op Binary reduction operator
* @param stream CUDA stream to use
* @return The reduction result
*/
Expand Down Expand Up @@ -309,7 +309,6 @@ bool any_of(InputIterator begin, InputIterator end, TransformOp op, rmm::cuda_st
*
* @param begin Device-accessible iterator to start of input values
* @param end Device-accessible iterator to end of input values
* @param init Initial value (unused, for API compatibility)
* @param op Predicate operator to apply to each element
* @param stream CUDA stream to use
* @return true if the predicate is false for all elements, false otherwise
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/copy_if_else.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -130,7 +130,7 @@ __launch_bounds__(block_size) CUDF_KERNEL
* @param rhs Begin iterator of rhs range
* @param filter Function of type `FilterFn` which determines for index `i` where to get the
* corresponding output value from
* @param out_type `cudf::data_type` of the returned column
* @param output_type `cudf::data_type` of the returned column
* @param stream CUDA stream used for device memory operations and kernel launches.
* @param mr Device memory resource used to allocate the returned column's device memory
* @return A new column that contains the values from either `lhs` or `rhs` as determined
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/gather.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2024, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -46,7 +46,7 @@ enum class negative_index_policy : bool { ALLOWED, NOT_ALLOWED };
* performance, use `DONT_CHECK` when the `gather_map` is known to contain only valid
* indices. If `policy` is set to `DONT_CHECK` and there are out-of-bounds indices in `gather_map`,
* the behavior is undefined.
* @param[in] negative_index_policy Interpret each negative index `i` in the
* @param[in] neg_indices Interpret each negative index `i` in the
* `gather_map` as the positive index `i+num_source_rows`.
* @param[in] stream CUDA stream used for device memory operations and kernel launches.
* @param[in] mr Device memory resource used to allocate the returned table's device memory
Expand Down
6 changes: 5 additions & 1 deletion cpp/include/cudf/detail/groupby/sort_helper.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2024, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -71,6 +71,8 @@ struct sort_groupby_helper {
* @throw cudf::logic_error if `values.size() != keys.num_rows()`
*
* @param values The value column to group and sort
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource used to allocate the returned device memory
* @return the sorted and grouped column
*/
std::unique_ptr<column> sorted_values(column_view const& values,
Expand All @@ -85,6 +87,8 @@ struct sort_groupby_helper {
* @throw cudf::logic_error if `values.size() != keys.num_rows()`
*
* @param values The value column to group
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource used to allocate the returned device memory
* @return the grouped column
*/
std::unique_ptr<column> grouped_values(column_view const& values,
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/detail/iterator.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct null_replaced_value_accessor {
* @throws cudf::logic_error if `has_nulls` is true but `col` does not have a validity mask.
*
* @param[in] col column device view of cudf column
* @param[in] null_replacement The value to return for null elements
* @param[in] null_val The value to return for null elements
* @param[in] has_nulls Must be set to true if `col` has nulls.
*/
null_replaced_value_accessor(column_device_view const& col,
Expand Down
1 change: 1 addition & 0 deletions cpp/include/cudf/detail/null_mask.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ size_type inplace_bitmask_binop(Binop op,
* This function performs bitwise operations on segments of bitmasks defined by segment_offsets,
* writing the results directly to the specified destination masks.
*
* @param[in] op The binary operation to apply
* @param[out] dest_masks Device span of pointers to destination bitmasks where results will be
* written
* @param[in] dest_mask_size The size of each destination mask in bitmask words
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf/detail/rolling.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2021-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -79,6 +79,7 @@ std::unique_ptr<column> rolling_window(column_view const& input,
* being sorted, must be sorted consistently with the @p order and @p null_order
* parameters.
* @param grouping Optional preprocessed grouping information.
* @param direction The window direction (preceding or following)
* @param order The sort order of the @p orderby column.
* @param null_order The sort order of nulls in the @p orderby column.
* @param window Descriptor specifying the window type.
Expand Down
2 changes: 0 additions & 2 deletions cpp/include/cudf/detail/scatter.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,6 @@ struct column_scatterer_impl<struct_view> {
* source columns to rows in the target columns
* @param[in] target The set of columns into which values from the source_table
* are to be scattered
* @param[in] check_bounds Optionally perform bounds checking on the values of
* `scatter_map` and throw an error if any of its values are out of bounds.
* @param[in] stream CUDA stream used for device memory operations and kernel launches.
* @param[in] mr Device memory resource used to allocate the returned table's device memory
*
Expand Down
1 change: 1 addition & 0 deletions cpp/include/cudf/detail/sizes_to_offsets_iterator.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,7 @@ static sizes_to_offsets_iterator<ScanIterator, LastType> make_sizes_to_offsets_i
* @param end End of the input iterator
* @param result Output iterator for scan result
* @param initial_offset Initial offset to add to scan
* @param stream CUDA stream used for device memory operations and kernel launches
* @return The last element of the scan
*/
template <typename SizesIterator, typename OffsetsIterator>
Expand Down
5 changes: 3 additions & 2 deletions cpp/include/cudf/detail/structs/utilities.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand Down Expand Up @@ -66,7 +66,8 @@ struct temporary_nullable_data {
* {{"abc", "def", "ghi"}, {"uvw", "xyz"} ]
* @endcode
*
* @param columns Vector of structs columns to extract from.
* @param struct_cols Vector of structs columns to extract from.
* @param stream CUDA stream used for device memory operations and kernel launches
* @return New column with concatenated results.
*/
std::vector<std::vector<column_view>> extract_ordered_struct_children(
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/tdigest/tdigest.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2021-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2021-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -218,7 +218,7 @@ std::unique_ptr<scalar> reduce_tdigest(column_view const& values,
* double // max
* }
*
* @param values tdigests to merge.
* @param input tdigests to merge.
* @param max_centroids Parameter controlling the level of compression of the tdigest. Higher
* values result in a larger, more precise tdigest.
* @param stream CUDA stream used for device memory operations and kernel launches.
Expand Down
7 changes: 2 additions & 5 deletions cpp/include/cudf/detail/timezone.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2023, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
Expand All @@ -17,10 +17,7 @@ namespace cudf::detail {
/**
* @brief Returns the UT offset for a given date and given timezone table.
*
* @param transition_times Transition times; trailing `solar_cycle_entry_count` entries are used for
* all times beyond the one covered by the TZif file
* @param offsets Time offsets in specific intervals; trailing `solar_cycle_entry_count` entries are
* used for all times beyond the one covered by the TZif file
* @param tz_table Timezone conversion table
* @param ts ORC timestamp
*
* @return offset from UT, in seconds
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf/detail/utilities/cuda.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2024-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2024-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -30,6 +30,7 @@ cudf::size_type num_multiprocessors();
* @param[in] kernel The kernel for which the elements per thread needs to be assessed
* @param[in] total_size Number of elements
* @param[in] block_size Expected block size
* @param[in] max_per_thread Maximum number of elements per thread
*
* @return cudf::size_type Elements per thread that can be processed for given specification.
*/
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/utilities/device_atomics.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -150,7 +150,7 @@ struct typesAtomicCASImpl {
* int8_t, int16_t, int32_t, int64_t, float, double
*
* @param address The address of old value in global or shared memory
* @param val The value to be computed
* @param update_value The value to be computed
* @param op The binary operator used for compute
*
* @returns The old value at `address`
Expand Down
7 changes: 3 additions & 4 deletions cpp/include/cudf/detail/utilities/grid_1d.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -81,10 +81,9 @@ class grid_1d {
*
* The returned stride is the total number of threads in the grid.
*
* @param thread_id The thread index within the block
* @param block_id The block index within the grid
* @param num_threads_per_block The number of threads per block
* @return thread_index_type The global thread index
* @param num_blocks_per_grid Number of blocks in the grid
* @return thread_index_type The grid stride
*/
__device__ static constexpr thread_index_type grid_stride(thread_index_type num_threads_per_block,
thread_index_type num_blocks_per_grid)
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/detail/utilities/host_vector.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ class rmm_host_allocator {
* with this \c rmm_host_allocator.
*
* @param p A \c pointer to the previously allocated memory.
* @note The second parameter is the number of objects previously allocated.
* @param cnt Number of objects that werepreviously allocated.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a space in this sentence. I also wish this was count...

Suggested change
* @param cnt Number of objects that werepreviously allocated.
* @param cnt Number of objects that were previously allocated.

* @note This method does not invoke \p value_type's destructor.
* It is the responsibility of the caller to destroy
* the objects stored at \p p.
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/utilities/vector_factories.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ std::vector<typename Container::value_type> make_std_vector_async(Container cons
* @note This function does a synchronize on `stream` after the copy.
*
* @tparam T The type of the data to copy
* @param source_data The device data to copy
* @param v The device data to copy
* @param stream The stream on which to perform the copy
* @return The data copied to the host
*/
Expand Down Expand Up @@ -410,7 +410,7 @@ host_vector<T> make_empty_host_vector(size_t capacity, rmm::cuda_stream_view str
* using a pinned memory resource.
*
* @tparam T The type of the data to copy
* @param source_data The device data to copy
* @param v The device data to copy
* @param stream The stream on which to perform the copy
* @return The data copied to the host
*/
Expand Down
3 changes: 2 additions & 1 deletion cpp/include/cudf/detail/valid_if.cuh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2025, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -73,6 +73,7 @@ CUDF_KERNEL void valid_if_kernel(
* @param end The end of the sequence
* @param p The predicate
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource used to allocate the returned device memory
* @return A pair containing a `device_buffer` with the new bitmask and its null count
*/
template <typename InputIterator, typename Predicate>
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/dictionary/detail/update_keys.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ std::vector<std::unique_ptr<column>> match_dictionaries(
*
* Any null rows are left unchanged.
*
* @param input Vector of cudf::table_views that include dictionary columns to be matched.
* @param tables Vector of cudf::table_views that include dictionary columns to be matched.
* @param stream CUDA stream used for device memory operations and kernel launches.
* @param mr Device memory resource used to allocate the returned column's device memory.
* @return New dictionary columns and updated cudf::table_views.
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/io/detail/csv.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2020-2024, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -17,7 +17,7 @@ namespace io::detail::csv {
/**
* @brief Reads the entire dataset.
*
* @param sources Input `datasource` object to read the dataset from
* @param source Input `datasource` object to read the dataset from
* @param options Settings for controlling reading behavior
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource to use for device memory allocation
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/io/detail/json.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2020-2024, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -59,7 +59,7 @@ void normalize_single_quotes(datasource::owning_buffer<rmm::device_buffer>& inda
/**
* @brief Normalize unquoted whitespace (space and tab characters) using FST
*
* @param indata Input device buffer
* @param d_input Input device buffer
* @param col_offsets Offsets to column contents in input buffer
* @param col_lengths Length of contents of each row in column
* @param stream CUDA stream used for device memory operations and kernel launches
Expand Down
Loading
Loading