Use reduction_axis for dataframes - #21743
Merged
Merged
Conversation
vyasr
requested review from
TomAugspurger and
rjzamora
and removed request for
a team
March 10, 2026 23:10
galipremsagar
approved these changes
Mar 10, 2026
When axis=None, reduction_axis is set to 2 but the subsequent branch checked 'if axis == 2' which was always False (axis remains None). Change to 'if reduction_axis == 2' so max/sum/product/median/etc. correctly reduce across all axes and return a scalar for pandas 3.0.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The variable conditionally reassigned in the code was changed previously but not the later conditional using that variable.
Before:
== 689 failed, 77747 passed, 19478 skipped, 1551 xfailed in 573.81s (0:09:33) ==After:
== 670 failed, 77766 passed, 19478 skipped, 1551 xfailed in 581.15s (0:09:41) ==Checklist