Move true_if device function from detail/.hpp to src/.cuh header - #21717
Merged
Conversation
davidwendt
added
libcudf
ttnghia
reviewed
Mar 9, 2026
ttnghia
reviewed
Mar 9, 2026
ttnghia
reviewed
Mar 9, 2026
bdice
approved these changes
Mar 10, 2026
ttnghia
approved these changes
Mar 10, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves a device function defined in
cpp/include/cudf/detail/unary.hppto newcpp/src/unary/true_if.cuhand update internal includes appropriately.The device function defined in a .hpp is unexpected and not needed to be available outside of the
cpp/src/unaryfolder.Also removes the
CUDF_EXPORTfrom thedetail/unary.hppdeclarations.Checklist