Skip to content

Support fixed point types in Parquet predicate pushdown - #21681

Merged
rapids-bot[bot] merged 15 commits into
NVIDIA:mainfrom
mhaseeb123:fix/decimal-support-pq-predicate-pushdown
Mar 10, 2026
Merged

Support fixed point types in Parquet predicate pushdown#21681
rapids-bot[bot] merged 15 commits into
NVIDIA:mainfrom
mhaseeb123:fix/decimal-support-pq-predicate-pushdown

Conversation

@mhaseeb123

@mhaseeb123 mhaseeb123 commented Mar 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Closes #21584

This PR enables proper support for fixed point (specifically decimal128) types in Parquet / Hybrid scan predicate pushdown

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mhaseeb123
mhaseeb123 requested a review from a team as a code owner March 6, 2026 04:17
@mhaseeb123
mhaseeb123 requested review from mythrocks and vyasr March 6, 2026 04:17
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 6, 2026
@mhaseeb123
mhaseeb123 requested review from mattgara and wence- March 6, 2026 04:17
@mhaseeb123 mhaseeb123 added bug Something isn't working 3 - Ready for Review Ready for review by team cuIO cuIO issue Velox Functionality that helps Velox-cudf non-breaking Non-breaking change labels Mar 6, 2026
wence-
wence- reviewed Mar 6, 2026
View reviewed changes
Comment thread cpp/src/io/parquet/stats_filter_helpers.hpp Outdated
@wence- wence- mentioned this pull request Mar 6, 2026
Closed
@GregoryKimball GregoryKimball moved this to Burndown in libcudf Mar 9, 2026
ttnghia
ttnghia reviewed Mar 9, 2026
View reviewed changes
Comment thread cpp/tests/io/parquet_reader_test.cpp Outdated
ttnghia
ttnghia reviewed Mar 9, 2026
View reviewed changes
Comment thread cpp/src/io/parquet/stats_filter_helpers.hpp Outdated
mhaseeb123 and others added 2 commits March 9, 2026 18:50
@mhaseeb123 @ttnghia
Update cpp/tests/io/parquet_reader_test.cpp
1750157 
Co-authored-by: Nghia Truong <7416935+ttnghia@users.noreply.github.com>
@mhaseeb123
Address comments
f01e6fb
@mhaseeb123
mhaseeb123 requested a review from ttnghia March 10, 2026 02:54
mhaseeb123
mhaseeb123 commented Mar 10, 2026
View reviewed changes
Comment thread cpp/tests/io/parquet_reader_test.cpp Outdated
@mhaseeb123 mhaseeb123 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 10, 2026
@mhaseeb123

mhaseeb123 commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit f537d4f into NVIDIA:main Mar 10, 2026
114 checks passed
@mhaseeb123
mhaseeb123 deleted the fix/decimal-support-pq-predicate-pushdown branch March 10, 2026 19:09
@mhaseeb123 mhaseeb123 moved this from Burndown to Landed in libcudf Mar 10, 2026
@GregoryKimball GregoryKimball removed this from libcudf Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wence- wence- wence- approved these changes
@ttnghia ttnghia ttnghia approved these changes
@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from rapidsai/cudf-cpp-codeowners
@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks was automatically assigned from rapidsai/cudf-cpp-codeowners
@mattgara mattgara Awaiting requested review from mattgara

Assignees

@mhaseeb123 mhaseeb123

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Velox Functionality that helps Velox-cudf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Parquet stats filters perform incorrect decoding for decimal128 stats

4 participants

@mhaseeb123 @wence- @ttnghia @GregoryKimball