Rename get_dtype_of_same_kind to get_dtype_of_same_variant and move to converters.py - #21376
Closed
mroeschke wants to merge 6 commits into
Closed
Rename get_dtype_of_same_kind to get_dtype_of_same_variant and move to converters.py#21376mroeschke wants to merge 6 commits into
mroeschke wants to merge 6 commits into
Conversation
Contributor
Author
|
I think the PR over-zealously assumes that an API will return the same variant as itself. But for example a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As we're working toward enabling native support for pandas extension types, #21229, we'll need to make heavy use of
get_dtype_of_same_kindto return an extension type if the input has an extension type.Similar to #21281, I think it's good opportunity to move this function to it's own
dtype/converters.pyfile, rename it toget_dtype_of_same_variant, and finish out it's implementation by usingfunctools.singledispatchto define all the conversions between dtype variants.Ops-Bot-Merge-Barrier: true
Checklist