-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add coarse-grained streaming-node tracing #21309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
64e6cb3
add ProfilingOptions
rjzamora 27cdf6e
revise
rjzamora 15e4bc6
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora 49c498c
cleanup and tests
rjzamora 08350a5
revise design
rjzamora 4d8a312
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora 126c916
tedious migration
rjzamora 1c5151e
remove unused allreduce def
rjzamora ee62732
Merge remote-tracking branch 'upstream/main' into channel-metadata-mi…
rjzamora d3b7583
update helper function
rjzamora bcb3168
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora 07443e5
cleanup and repartition
rjzamora c8be098
leave out rows when unknown
rjzamora fe2aefd
Merge branch 'main' into profiling-config
rjzamora 05df373
leave off static partition count
rjzamora 032d13d
improve cov
rjzamora 3a8b3b8
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora d0bf467
more coverage
rjzamora 74737c5
missed a line
rjzamora 3634c98
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora f77569a
Merge branch 'main' into channel-metadata-migration
rjzamora 206f9f7
Merge branch 'main' into channel-metadata-migration
rjzamora 6f8c5e2
Merge branch 'main' into profiling-config
rjzamora 6d7b972
align with rjzamora:channel-metadata-migration (since that is merging…
rjzamora 22e58c5
Merge remote-tracking branch 'upstream/main' into profiling-config
rjzamora c44ae02
simplify explain.py logic
rjzamora 8800222
reuse code
rjzamora 09a0aac
add structlog tracing
rjzamora 4ef47f7
Merge remote-tracking branch 'upstream/main' into structlog-profiling
rjzamora 1c80b1b
add structlog events to RuntimeNodeProfiler
rjzamora 1347562
use 'tracing' name for consistency
rjzamora 96c5739
adopt 'tracing' terminology
rjzamora 75db21e
move import
rjzamora 20f26e4
fixes
rjzamora 72a0916
clean up docstring
rjzamora 0b78906
Merge remote-tracking branch 'upstream/main' into structlog-profiling
rjzamora f3027ba
Merge remote-tracking branch 'upstream/main' into structlog-profiling
rjzamora 694cf89
partial code review
rjzamora 459f780
partial code review (2)
rjzamora 09ad6cc
drop unnecessary check
rjzamora 22bb44e
Merge remote-tracking branch 'upstream/main' into structlog-profiling
rjzamora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have an option to dump this tree in a structured form (json would be fine)? That way automated tools have a chance of reading it rather than needing to parse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm working on that and will have something later today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will already dump the information in structlog form when
CUDF_POLARS_LOG_TRACES=1. Tom is working on the code needed to post-process that output to provide something similar to the above. I suppose we could drop some of this logic if we feel like the dump + post-process workflow works well enough for multiple ranks.